mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-17 13:38:32 +01:00
Code Issues Projects Releases Wiki Activity

MDL-71494 mod_feedback: final removal of deprecated constructor param.

Browse Source
This commit is contained in:
Paul Holden 2023-07-26 16:58:57 +01:00
parent 206c3a66e7
commit 56cd63a8f9
No known key found for this signature in database
GPG Key ID: A81A96D6045F6164
2 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
mod/feedback/classes/output/summary.php
View File

@ -49,15 +49,10 @@ class summary implements renderable, templatable {
/**
* Constructor.
*
* @todo MDL-71494 Final deprecation of the $extradetails parameter in Moodle 4.3
* @param mod_feedback_structure $feedbackstructure
* @param int $mygroupid currently selected group
* @param bool|null $extradetails Deprecated
*/
public function __construct($feedbackstructure, $mygroupid = false, $extradetails = null) {
if (isset($extradetails)) {
debugging('The $extradetails parameter is deprecated.', DEBUG_DEVELOPER);
}
public function __construct($feedbackstructure, $mygroupid = false) {
$this->feedbackstructure = $feedbackstructure;
$this->mygroupid = $mygroupid;
}

7
mod/feedback/upgrade.txt
View File

@ -1,3 +1,10 @@
This file describes API changes in /mod/feedback/*
Information provided here is intended especially for developers.
=== 4.3 ===
* The `$extradetails` parameter of the `\mod_feedback\output\summary` class constructor has been removed
=== 4.2 ===
* The external methods get_items() and get_page_items() now only return the items when the user can access the feedback; if the
user can't see them, a warning message will be returned, with the reasons.