From b952441d226d44a1cedb49c283b03520a194ec40 Mon Sep 17 00:00:00 2001 From: "Eloy Lafuente (stronk7)" Date: Thu, 24 Mar 2022 20:02:23 +0100 Subject: [PATCH] MDL-74320 lesson: Remove tested elsewhere parts of the scenario The scenario has not only grades related completion conditions but also timing conditions or reach the end conditions that shouldn't be tested by a grades feature. More yet, those completion conditions are already tested by other feature files, namely: - reach the end: completion_condition_end_reached.feature - visit and timing: lesson_activity_completion.feature So we have removed all those parts that are being tested by other features. Specially the visit and timing ones, because they lead to random failures in slow environments and they have been fixed in the lesson_activity_completion.feature scenarios by MDL-72698. --- .../lesson_completion_pass_grade.feature | 24 ------------------- 1 file changed, 24 deletions(-) diff --git a/mod/lesson/tests/behat/lesson_completion_pass_grade.feature b/mod/lesson/tests/behat/lesson_completion_pass_grade.feature index 4b909e09ad1..9065df3d09b 100644 --- a/mod/lesson/tests/behat/lesson_completion_pass_grade.feature +++ b/mod/lesson/tests/behat/lesson_completion_pass_grade.feature @@ -33,12 +33,8 @@ Feature: Pass grade activity completion in the lesson activity | section | 1 | | gradepass | 50 | | completion | 2 | - | completionview | 1 | | completionusegrade | 1 | | completionpassgrade | 1 | - | completionendreached | 1 | - | completiontimespentenabled | 1 | - | completiontimespent | 1 | And I am on "Course 1" course homepage And I follow "Music history" And I follow "Add a question page" @@ -58,43 +54,23 @@ Feature: Pass grade activity completion in the lesson activity Given I log in as "teacher1" And I am on "Course 1" course homepage When I follow "Music history" - Then "Music history" should have the "View" completion condition - And "Music history" should have the "Spend at least 1 sec on this activity" completion condition - And "Music history" should have the "Go through the activity to the end" completion condition And "Music history" should have the "Receive a grade" completion condition And "Music history" should have the "Receive a passing grade" completion condition Scenario: View automatic completion items as a student Given I am on the "Music history" "lesson activity" page logged in as student1 - And the "View" completion condition of "Music history" is displayed as "done" - And the "Spend at least 1 sec on this activity" completion condition of "Music history" is displayed as "todo" - And the "Go through the activity to the end" completion condition of "Music history" is displayed as "todo" And the "Receive a grade" completion condition of "Music history" is displayed as "todo" And the "Receive a passing grade" completion condition of "Music history" is displayed as "todo" When I am on "Course 1" course homepage And I follow "Music history" - And I wait "2" seconds - And I reload the page - And the "View" completion condition of "Music history" is displayed as "done" - And the "Spend at least 1 sec on this activity" completion condition of "Music history" is displayed as "done" - And the "Go through the activity to the end" completion condition of "Music history" is displayed as "todo" - And the "Receive a grade" completion condition of "Music history" is displayed as "todo" - And the "Receive a passing grade" completion condition of "Music history" is displayed as "todo" And I set the field "Your answer" to "3" And I press "Submit" - Then the "View" completion condition of "Music history" is displayed as "done" - And the "Spend at least 1 sec on this activity" completion condition of "Music history" is displayed as "done" - And the "Go through the activity to the end" completion condition of "Music history" is displayed as "done" And the "Receive a grade" completion condition of "Music history" is displayed as "done" And the "Receive a passing grade" completion condition of "Music history" is displayed as "done" And I log out And I am on the "Music history" "lesson activity" page logged in as student2 - And I wait "2" seconds And I set the field "Your answer" to "0" And I press "Submit" - Then the "View" completion condition of "Music history" is displayed as "done" - And the "Spend at least 1 sec on this activity" completion condition of "Music history" is displayed as "done" - And the "Go through the activity to the end" completion condition of "Music history" is displayed as "done" And the "Receive a grade" completion condition of "Music history" is displayed as "done" And the "Receive a passing grade" completion condition of "Music history" is displayed as "failed" And I log out