mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-17 21:49:15 +01:00
Code Issues Projects Releases Wiki Activity

MDL-76071 mod_choice: fix choice display on graphs

Browse Source 
* The setting "Display mode" modifies the choices alignment of radio choice button
from horizontally to vertically. It should also display the list of choices in
the graph in the same directions.
This commit is contained in:
Laurent David 2022-10-25 10:11:00 +02:00
parent 046e48c49c
commit 5a1e8156d7
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
mod/choice/renderer.php
View File

@ -22,9 +22,6 @@
* @copyright 2010 Rossiani Wijaya
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
**/
define ('DISPLAY_HORIZONTAL_LAYOUT', 0);
define ('DISPLAY_VERTICAL_LAYOUT', 1);
class mod_choice_renderer extends plugin_renderer_base {
/**
@ -374,7 +371,7 @@ class mod_choice_renderer extends plugin_renderer_base {
* Can be displayed either in the vertical or horizontal position.
*
* @param stdClass $choices Choices responses object.
* @param int $displaylayout The constants DISPLAY_HORIZONTAL_LAYOUT or DISPLAY_VERTICAL_LAYOUT.
* @param int $displaylayout The constants CHOICE_DISPLAY_HORIZONTAL or CHOICE_DISPLAY_VERTICAL.
* @return string the rendered chart.
*/
public function display_publish_anonymous($choices, $displaylayout) {
@ -397,8 +394,8 @@ class mod_choice_renderer extends plugin_renderer_base {
}
$chart = new \core\chart_bar();
if ($displaylayout == DISPLAY_HORIZONTAL_LAYOUT) {
$chart->set_horizontal(true);
if ($displaylayout == CHOICE_DISPLAY_VERTICAL) {
$chart->set_horizontal(true); // Horizontal bars when choices are vertical.
}
$series = new \core\chart_series(format_string(get_string("responses", "choice")), $data['series']);
$series->set_labels($data['series_labels']);