mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-15 05:25:08 +02:00
Code Issues Projects Releases Wiki Activity

MDL-65928 mod_choice: Use proper string for 'select/deselect all' labels

Browse Source 
* Because string concatenation is bad!
This commit is contained in:
Jun Pataleta 2019-07-12 15:43:40 +08:00
parent 05b25140d0
commit 622d83d7bc
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mod/choice/lang/en/choice.php
View File

@ -70,6 +70,7 @@ $string['choice:view'] = 'View choice activity';
$string['chooseaction'] = 'Choose an action ...';
$string['chooseoption'] = 'Choose: {$a}';
$string['description'] = 'Description';
$string['deselectalloption'] = 'Deselect all "{$a}"';
$string['includeinactive'] = 'Include responses from inactive/suspended users';
$string['indicator:cognitivedepth'] = 'Choice cognitive';
$string['indicator:cognitivedepth_help'] = 'This indicator is based on the cognitive depth reached by the student in a Choice activity.';
@ -134,6 +135,7 @@ $string['responsesto'] = 'Responses to {$a}';
$string['results'] = 'Results';
$string['savemychoice'] = 'Save my choice';
$string['search:activity'] = 'Choice - activity information';
$string['selectalloption'] = 'Select all "{$a}"';
$string['showpreview'] = 'Show preview';
$string['showpreview_help'] = 'Allow students to preview the available options before the choice is opened for submission.';
$string['showunanswered'] = 'Show column for unanswered';

4
mod/choice/renderer.php
View File

@ -193,8 +193,8 @@ class mod_choice_renderer extends plugin_renderer_base {
// Build the select/deselect all for this option.
$selectallid = 'select-response-option-' . $optionid;
$togglegroup = 'responses response-option-' . $optionid;
$selectalltext = get_string('selectall', 'moodle') . ' ' . $headertitle;
$deselectalltext = get_string('deselectall', 'moodle') . ' ' . $headertitle;
$selectalltext = get_string('selectalloption', 'choice', $headertitle);
$deselectalltext = get_string('deselectalloption', 'choice', $headertitle);
$mastercheckbox = new \core\output\checkbox_toggleall($togglegroup, true, [
'id' => $selectallid,
'name' => $selectallid,