mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-03-14 12:40:01 +01:00
Code Issues Projects Releases Wiki Activity

enrol/database MDL-19445 Fixed infinite loops and removed superfluous objects and casts.

Browse Source 
thanks to Daren Chandisingh for the patch
This commit is contained in:
Dan Poltawski 2009-11-16 10:53:23 +00:00
parent 50aca34443
commit 62d887ecc8
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
enrol/database/enrol.php
View File

@ -84,9 +84,9 @@ function setup_enrolments(&$user) {
//$count = 0;
$courselist = array();
while ($fields_obj = (object)$rs->FetchRow()) { // Make a nice little array of courses to process
$fields_obj = (object)array_change_key_case((array)$fields_obj , CASE_LOWER);
$courselist[] = $fields_obj->enrolremotecoursefield;
while ($fields = $rs->FetchRow()) { // Make a nice little array of courses to process
$fields = array_change_key_case($fields, CASE_LOWER);
$courselist[] = $fields['enrolremotecoursefield'];
//$count++;
}
$rs->close();
@ -223,9 +223,9 @@ function sync_enrolments($role = null) {
$transaction = $DB->start_delegated_transaction();
$extcourses = array();
while ($extcourse_obj = (object)$rs->FetchRow()) { // there are more course records
$extcourse_obj = (object)array_change_key_case((array)$extcourse_obj , CASE_LOWER);
$extcourse = $extcourse_obj->{strtolower($CFG->enrol_remotecoursefield)};
while ($rsextcourse = $rs->FetchRow()) { // there are more course records
$rsextcourse = array_change_key_case($rsextcourse, CASE_LOWER);
$extcourse = $rsextcourse[strtolower($CFG->enrol_remotecoursefield)];
array_push($extcourses, $extcourse);
// does the course exist in moodle already?
@ -279,9 +279,9 @@ function sync_enrolments($role = null) {
}
// slurp results into an array
while ($crs_obj = (object)$crs->FetchRow()) {
$crs_obj = (object)array_change_key_case((array)$crs_obj , CASE_LOWER);
array_push($extenrolments, $crs_obj->{strtolower($CFG->enrol_remoteuserfield)});
while ($rscrs = $crs->FetchRow()) {
$rscrs = array_change_key_case($rscrs, CASE_LOWER);
array_push($extenrolments, $rscrs[strtolower($CFG->enrol_remoteuserfield)]);
}
$crs->close(); // release the handle