mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-03-13 20:26:32 +01:00
Code Issues Projects Releases Wiki Activity

MDL-52168 mod_scorm: Fix issue when scorm does not define org.

Browse Source
This commit is contained in:
Dan Marsden 2015-11-16 16:54:45 +00:00
parent c4cf1c60f5
commit 63c2ea5038
4 changed files with 39 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mod/scorm/datamodels/scorm_12.js
View File

@ -169,7 +169,7 @@ function SCORMapi1_2(def, cmiobj, cmiint, cmistring256, cmistring4096, scormdebu
var Initialized = false;
function LMSInitialize (param) {
scoid = scorm_current_node ? scorm_current_node.scoid : scoid;
scoid = (scorm_current_node && scorm_current_node.scoid) ? scorm_current_node.scoid : scoid;
initdatamodel(scoid);
errorCode = "0";

36
mod/scorm/tests/behat/missing_org.feature Normal file
View File

@ -0,0 +1,36 @@
@mod @mod_scorm @_file_upload @_switch_iframe
Feature: Check a SCORM package with missing Organisational structure.
@javascript
Scenario: Add a scorm activity to a course
Given the following "users" exist:
| username | firstname | lastname | email |
| teacher1 | Teacher | 1 | teacher1@example.com |
| student1 | Student | 1 | student1@example.com |
And the following "courses" exist:
| fullname | shortname | category |
| Course 1 | C1 | 0 |
And the following "course enrolments" exist:
| user | course | role |
| teacher1 | C1 | editingteacher |
| student1 | C1 | student |
When I log in as "teacher1"
And I follow "Course 1"
And I turn editing mode on
And I add a "SCORM package" to section "1"
And I set the following fields to these values:
| Name | MissingOrg SCORM package |
| Description | Description |
And I upload "mod/scorm/tests/packages/singlescobasic_missingorg.zip" file to "Package file" filemanager
And I click on "Save and display" "button"
Then I should see "MissingOrg SCORM package"
And I should see "Normal"
And I should see "Preview"
And I log out
And I log in as "student1"
And I follow "Course 1"
And I follow "MissingOrg SCORM package"
And I should see "Normal"
And I press "Enter"
And I switch to "scorm_object" iframe
And I should see "Play of the game"

3
mod/scorm/tests/packages/readme_moodle.txt
View File

@ -17,4 +17,5 @@ Other test packages
* invalid.zip - zip file with an single html file, no SCORM config files, used for validation check.
* validscorm.zip - non functional package with an imsmanifest.xml, used for validation check.
* validaicc.zip - non functional package with AICC config files, used for validation check.
* complexscorm.zip - copied from: https://github.com/jleyva/scorm-debugger
* complexscorm.zip - copied from: https://github.com/jleyva/scorm-debugger.
* singlescobasic_missingorg.zip - copy of scorm.com package but with missing org definition.

BIN
mod/scorm/tests/packages/singlescobasic_missingorg.zip Normal file
View File

Binary file not shown.