mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-22 00:42:54 +02:00
Code Issues Projects Releases Wiki Activity

MDL-79062 gradereport_grader: Set numeric type for grade value inputs

Browse Source 
* Set grade inputs for grade items with type set to GRADE_VALUE to
number and add min and max input attributes, where necessary.
This commit is contained in:
Jun Pataleta 2023-10-18 17:40:05 +08:00
parent 15409cfa41
commit 6637197d97
No known key found for this signature in database
GPG Key ID: F83510526D99E2C7
1 changed files with 27 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
grade/report/grader/lib.php
View File

@ -1143,9 +1143,33 @@ class grade_report_grader extends grade_report {
$gradelabel = $fullname . ' ' . $item->get_name(true);
$itemcell->text .= '<label class="accesshide" for="grade_'.$userid.'_'.$item->id.'">'
.get_string('useractivitygrade', 'gradereport_grader', $gradelabel).'</label>';
$itemcell->text .= '<input size="6" '
. ' type="text" class="text" title="'. $strgrade .'" name="grade['
.$userid.'][' .$item->id.']" id="grade_'.$userid.'_'.$item->id.'" value="'.$value.'" />';
// Set this input field with type="number" if the decimal separator for current language is set to
// a period. Other decimal separators may not be recognised by browsers yet which may cause issues
// when entering grades.
$decsep = get_string('decsep', 'core_langconfig');
$isnumeric = $decsep === '.';
$inputtype = $isnumeric ? 'number' : 'text';
$inputparams = [
'type' => $inputtype,
'class' => 'text',
'title' => $strgrade,
'name' => "grade[{$userid}][{$item->id}]",
'id' => "grade_{$userid}_{$item->id}",
'value' => $value,
];
// If we're rendering this as a number field, set step and min/max attributes (if applicable).
if ($isnumeric) {
$inputparams['step'] = 'any';
if (isset($item->grademin)) {
$inputparams['min'] = $item->grademin;
}
if (isset($item->grademax)) {
$inputparams['max'] = $item->grademax;
}
}
$itemcell->text .= html_writer::empty_tag('input', $inputparams);
} else {
$itemcell->text .= $gradepassicon . "<span class='gradevalue{$hidden}{$gradepass}'>" .
format_float($gradeval, $decimalpoints) . "</span>";