mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-19 06:18:28 +01:00
Code Issues Projects Releases Wiki Activity

Fixing a serious bug with PHP 5 only, which caused blocks to lose

Browse Source 
their configuration data (there is an explanation but I don't think
anyone cares).

Actually it was an optimization and I had to disable it. All is fine now.
This commit is contained in:
defacer 2005-02-05 01:32:15 +00:00
parent 93334ad588
commit 673c1b2f13
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
blocks/moodleblock.class.php
View File

@ -461,7 +461,11 @@ class block_base {
if (!empty($instance->configdata)) {
$this->config = unserialize(base64_decode($instance->configdata));
}
unset($instance->configdata);
// [pj] This line below is supposed to be an optimization (we don't need configdata anymore)
// but what it does is break in PHP5 because the same instance object will be passed to
// this function twice in each page view, and the second time it won't have any configdata
// so it won't work correctly. Thus it's commented out.
// unset($instance->configdata);
$this->instance = $instance;
$this->specialization();
}