mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-21 00:12:56 +02:00
Code Issues Projects Releases Wiki Activity

Changing some hardwired 1s to SITEID. Is the madness ever going to end?

Browse Source 
Use 1 as a magic number in code, pay the price...
This commit is contained in:
defacer 2005-08-23 20:43:32 +00:00
parent a04e6f5690
commit 69963aa63c
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
calendar/view.php
View File

@ -85,7 +85,7 @@
// If a course has been supplied in the URL, change the filters to show that one
if (!empty($course)) {
if ($course = get_record('course', 'id', $course)) {
if ($course->id == 1) {
if ($course->id == SITEID) {
// If coming from the home page, show all courses
$SESSION->cal_courses_shown = calendar_get_default_courses(true);
calendar_set_referring_course(0);
@ -108,7 +108,7 @@
// Let's see if we are supposed to provide a referring course link
// but NOT for the "main page" course
if ($SESSION->cal_course_referer > 1 &&
if ($SESSION->cal_course_referer != SITEID &&
($shortname = get_field('course', 'shortname', 'id', $SESSION->cal_course_referer)) !== false) {
// If we know about the referring course, show a return link and ALSO require login!
require_login();
@ -558,7 +558,7 @@ function calendar_course_filter_selector($getvars = '') {
unset($courses[SITEID]);
$courseoptions[1] = get_string('fulllistofcourses');
$courseoptions[SITEID] = get_string('fulllistofcourses');
foreach ($courses as $course) {
$courseoptions[$course->id] = $course->shortname;
}