mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-21 00:12:56 +02:00
Code Issues Projects Releases Wiki Activity

MDL-45171 log reports: fix sql for cross support

Browse Source 
Rules for cross-db support are:

- Always use the 'AS' keyword for columns.
- Never use the 'AS' keyword for tables/views.
This commit is contained in:
Eloy Lafuente (stronk7) 2014-04-18 17:34:06 +02:00
parent a0461340ff
commit 6b139edaf9
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
report/log/classes/table_log.php
View File

@ -481,7 +481,7 @@ class report_log_table_log extends table_sql {
$ccselect = ', ' . context_helper::get_preload_record_columns_sql('ctx');
$ccjoin = "LEFT JOIN {context} ctx ON (ctx.instanceid = c.id AND ctx.contextlevel = :contextlevel)";
$courseparams['contextlevel'] = CONTEXT_COURSE;
$sql = "SELECT c.id,c.shortname $ccselect FROM {course} as c
$sql = "SELECT c.id,c.shortname $ccselect FROM {course} c
$ccjoin
WHERE c.id " . $coursesql;
@ -496,4 +496,4 @@ class report_log_table_log extends table_sql {
}
}
}
}
}

2
report/loglive/classes/table_log.php
View File

@ -387,7 +387,7 @@ class report_loglive_table_log extends table_sql {
$ccselect = ', ' . context_helper::get_preload_record_columns_sql('ctx');
$ccjoin = "LEFT JOIN {context} ctx ON (ctx.instanceid = c.id AND ctx.contextlevel = :contextlevel)";
$courseparams['contextlevel'] = CONTEXT_COURSE;
$sql = "SELECT c.id,c.shortname $ccselect FROM {course} as c
$sql = "SELECT c.id,c.shortname $ccselect FROM {course} c
$ccjoin
WHERE c.id " . $coursesql;