Merged from MOODLE_14_STABLE: Fixing use of UCASE and LCASE in glossary which are not postgres friendly - two new functions in datalib, db_uppercase and db_lowercase which return the database-correct functions to use. Some were already fixed in HEAD - those have been left as they were

lib/datalib.php

@@ -80,6 +80,41 @@ function begin_sql() {
     }
     return true;
 }
+
+/**
+ * returns db specific uppercase function
+ */
+function db_uppercase() {
+    global $CFG;
+    switch (strtolower($CFG->dbtype)) {
+
+    case "postgres7":
+        return "upper";
+        break;
+    case "mysql":
+    default:
+        return "ucase";
+        break;
+    }
+}
+
+/**
+ * returns db specific lowercase function
+ */
+function db_lowercase() {
+    global $CFG;
+    switch (strtolower($CFG->dbtype)) {
+
+    case "postgres7":
+        return "lower";
+        break;
+    case "mysql":
+    default:
+        return "lcase";
+        break;
+    }
+}
+
 /**
 * on DBs that support it, commit the transaction 
 */

mod/glossary/editcategories.php

@@ -132,7 +132,8 @@
 
     } elseif ( $action == "add" ) {
         if ( $confirm ) {
-            $dupcategory = get_record("glossary_categories","lcase(name)",strtolower($name),"glossaryid",$glossary->id);
+            $lcase = db_lowercase();
+            $dupcategory = get_record("glossary_categories","$lcase(name)",strtolower($name),"glossaryid",$glossary->id);
             if ( $dupcategory ) {
                 echo "<p align=\"center\">" . get_string("add"). " " . get_string("category","glossary") . "<font size=\"3\">";