mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-17 21:49:15 +01:00
Code Issues Projects Releases Wiki Activity

MDL-72772 gradereport_overview: account for users with parent roles.

Browse Source
This commit is contained in:
Paul Holden 2022-01-12 11:07:34 +00:00 committed by Eloy Lafuente (stronk7)
parent 7cba3c5d13
commit 6d18f136ae
2 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
course/user.php
View File

@ -193,7 +193,9 @@ switch ($mode) {
require_once $CFG->dirroot.'/grade/report/'.$CFG->grade_profilereport.'/lib.php';
// User must be able to view this grade report.
require_capability('gradereport/' . $CFG->grade_profilereport .':view', $coursecontext);
if (!$viewasuser) {
require_capability('gradereport/' . $CFG->grade_profilereport . ':view', $coursecontext);
}
$functionname = 'grade_report_'.$CFG->grade_profilereport.'_profilereport';
if (function_exists($functionname)) {

12
grade/report/overview/lib.php
View File

@ -272,6 +272,12 @@ class grade_report_overview extends grade_report {
if ($this->courses) {
$coursesdata = $this->setup_courses_data($studentcoursesonly);
// Check whether current user can view all grades of this user - parent most probably.
$viewasuser = $this->course->showgrades && has_any_capability([
'moodle/grade:viewall',
'moodle/user:viewuseractivitiesreport',
], context_user::instance($this->user->id));
foreach ($coursesdata as $coursedata) {
$course = $coursedata['course'];
@ -282,13 +288,15 @@ class grade_report_overview extends grade_report {
$coursenamelink = format_string(get_course_display_name_for_list($course), true, ['context' => $coursecontext]);
// Link to the course grade report pages (performing same capability checks as the pages themselves).
if ($activitylink && has_capability('gradereport/' . $CFG->grade_profilereport .':view', $coursecontext)) {
if ($activitylink &&
(has_capability('gradereport/' . $CFG->grade_profilereport .':view', $coursecontext) || $viewasuser)) {
$coursenamelink = html_writer::link(new moodle_url('/course/user.php', [
'mode' => 'grade',
'id' => $course->id,
'user' => $this->user->id,
]), $coursenamelink);
} else if (!$activitylink && has_capability('gradereport/user:view', $coursecontext)) {
} else if (!$activitylink && (has_capability('gradereport/user:view', $coursecontext) || $viewasuser)) {
$coursenamelink = html_writer::link(new moodle_url('/grade/report/user/index.php', [
'id' => $course->id,
'userid' => $this->user->id,