mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-21 00:12:56 +02:00
Code Issues Projects Releases Wiki Activity

MDL-51715 lib/grade: Unit test for aggregationweight

Browse Source
This commit is contained in:
Colin Campbell 2015-11-02 09:45:36 -06:00
parent 70ba1f6bcb
commit 7006ab3eb7
1 changed files with 59 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

59
lib/grade/tests/grade_category_test.php
View File

@ -49,6 +49,7 @@ class core_grade_category_testcase extends grade_base_testcase {
$this->sub_test_grade_category_load_parent_category();
$this->sub_test_grade_category_get_parent_category();
$this->sub_test_grade_category_get_name();
$this->sub_test_grade_category_generate_grades_aggregationweight();
$this->sub_test_grade_category_set_parent();
$this->sub_test_grade_category_get_final();
$this->sub_test_grade_category_get_sortorder();
@ -238,6 +239,64 @@ class core_grade_category_testcase extends grade_base_testcase {
$this->assertEquals(1, $grade_category->grade_item->needsupdate);
}
/**
* Tests the setting of the grade_grades aggregationweight column.
* Currently, this is only a regression test for MDL-51715.
* This must be run before sub_test_grade_category_set_parent(), which alters
* the fixture.
*/
protected function sub_test_grade_category_generate_grades_aggregationweight() {
global $DB;
// Start of regression test for MDL-51715.
// grade_categories [1] and [2] are child categories of [0]
// Ensure that grades have been generated with fixture data.
$childcat1 = new grade_category($this->grade_categories[1]);
$childcat1itemid = $childcat1->load_grade_item()->id;
$childcat1->generate_grades();
$childcat2 = new grade_category($this->grade_categories[2]);
$childcat2itemid = $childcat2->load_grade_item()->id;
$childcat2->generate_grades();
$parentcat = new grade_category($this->grade_categories[0]);
$parentcat->generate_grades();
// Drop low and and re-generate to produce 'dropped' aggregation status.
$parentcat->droplow = 1;
$parentcat->generate_grades();
$this->assertTrue($DB->record_exists_select(
'grade_grades',
"aggregationstatus='dropped' and itemid in (?,?)",
array($childcat1itemid, $childcat2itemid)));
$this->assertFalse($DB->record_exists_select(
'grade_grades',
"aggregationstatus='dropped' and aggregationweight > 0.00"),
"aggregationweight should be 0.00 if aggregationstatus=='dropped'");
// Reset grade data to be consistent with fixture data.
$parentcat->droplow = 0;
$parentcat->generate_grades();
// Blank out the final grade for one of the child categories and re-generate
// to produce 'novalue' aggregationstatus. Direct DB update is testing shortcut.
$DB->set_field('grade_grades', 'finalgrade', null, array('itemid'=>$childcat1itemid));
$parentcat->generate_grades();
$this->assertTrue($DB->record_exists_select(
'grade_grades',
"aggregationstatus='novalue' and itemid = ?",
array($childcat1itemid)));
$this->assertFalse($DB->record_exists_select(
'grade_grades',
"aggregationstatus='novalue' and aggregationweight > 0.00"),
"aggregationweight should be 0.00 if aggregationstatus=='novalue'");
// Re-generate to be consistent with fixture data.
$childcat1->generate_grades();
$parentcat->generate_grades();
// End of regression test for MDL-51715.
}
/**
* Tests the calculation of grades using the various aggregation methods with and without hidden grades
* This will not work entirely until MDL-11837 is done