MDL-79397 reportbuilder: update existing entity table definitions.

admin/classes/reportbuilder/local/entities/task_log.php

@@ -46,12 +46,14 @@ class task_log extends base {
     protected const FAILED = 1;
 
     /**
-     * Database tables that this entity uses and their default aliases
+     * Database tables that this entity uses
      *
-     * @return array
+     * @return string[]
      */
-    protected function get_default_table_aliases(): array {
+    protected function get_default_tables(): array {
-        return ['task_log' => 'tl'];
+        return [
+            'task_log',
+        ];
     }
 
     /**

admin/roles/classes/reportbuilder/local/entities/role.php

@@ -34,14 +34,14 @@ use core_reportbuilder\local\report\{column, filter};
 class role extends base {
 
     /**
-     * Database tables that this entity uses and their default aliases
+     * Database tables that this entity uses
      *
-     * @return array
+     * @return string[]
      */
-    protected function get_default_table_aliases(): array {
+    protected function get_default_tables(): array {
         return [
-            'context' => 'rctx',
+            'context',
-            'role' => 'r',
+            'role',
         ];
     }
 

badges/classes/reportbuilder/local/entities/badge.php

@@ -44,16 +44,16 @@ require_once("{$CFG->libdir}/badgeslib.php");
 class badge extends base {
 
     /**
-     * Database tables that this entity uses and their default aliases
+     * Database tables that this entity uses
      *
-     * @return array
+     * @return string[]
      */
-    protected function get_default_table_aliases(): array {
+    protected function get_default_tables(): array {
         return [
-            'badge' => 'b',
+            'badge',
-            'context' => 'bctx',
+            'context',
-            'tag_instance' => 'bti',
+            'tag_instance',
-            'tag' => 'bt',
+            'tag',
         ];
     }
 

badges/classes/reportbuilder/local/entities/badge_issued.php

@@ -34,12 +34,14 @@ use core_reportbuilder\local\report\{column, filter};
 class badge_issued extends base {
 
     /**
-     * Database tables that this entity uses and their default aliases
+     * Database tables that this entity uses
      *
-     * @return array
+     * @return string[]
      */
-    protected function get_default_table_aliases(): array {
+    protected function get_default_tables(): array {
-        return ['badge_issued' => 'bi'];
+        return [
+            'badge_issued',
+        ];
     }
 
     /**

blog/classes/reportbuilder/local/entities/blog.php

@@ -38,15 +38,15 @@ use core_reportbuilder\local\report\{column, filter};
 class blog extends base {
 
     /**
-     * Database tables that this entity uses and their default aliases
+     * Database tables that this entity uses
      *
-     * @return array
+     * @return string[]
      */
-    protected function get_default_table_aliases(): array {
+    protected function get_default_tables(): array {
         return [
-            'post' => 'bp',
+            'post',
-            'tag_instance' => 'bti',
+            'tag_instance',
-            'tag' => 'bt',
+            'tag',
         ];
     }
 

cohort/classes/reportbuilder/local/entities/cohort.php

@@ -42,14 +42,14 @@ use core_reportbuilder\local\report\filter;
 class cohort extends base {
 
     /**
-     * Database tables that this entity uses and their default aliases
+     * Database tables that this entity uses
      *
-     * @return array
+     * @return string[]
      */
-    protected function get_default_table_aliases(): array {
+    protected function get_default_tables(): array {
         return [
-            'cohort' => 'c',
+            'cohort',
-            'context' => 'chctx',
+            'context',
         ];
     }
 

cohort/classes/reportbuilder/local/entities/cohort_member.php

@@ -35,12 +35,14 @@ use core_reportbuilder\local\report\filter;
 class cohort_member extends base {
 
     /**
-     * Database tables that this entity uses and their default aliases
+     * Database tables that this entity uses
      *
-     * @return array
+     * @return string[]
      */
-    protected function get_default_table_aliases(): array {
+    protected function get_default_tables(): array {
-        return ['cohort_members' => 'cm'];
+        return [
+            'cohort_members',
+        ];
     }
 
     /**

comment/classes/reportbuilder/local/entities/comment.php

@@ -38,14 +38,14 @@ use core_reportbuilder\local\report\{column, filter};
 class comment extends base {
 
     /**
-     * Database tables that this entity uses and their default aliases
+     * Database tables that this entity uses
      *
-     * @return array
+     * @return string[]
      */
-    protected function get_default_table_aliases(): array {
+    protected function get_default_tables(): array {
         return [
-            'comments' => 'c',
+            'comments',
-            'context' => 'cmctx',
+            'context',
         ];
     }
 

course/classes/reportbuilder/local/entities/access.php

@@ -36,12 +36,15 @@ use stdClass;
 class access extends base {
 
     /**
-     * Database tables that this entity uses and their default aliases
+     * Database tables that this entity uses
      *
-     * @return array
+     * @return string[]
      */
-    protected function get_default_table_aliases(): array {
+    protected function get_default_tables(): array {
-        return ['user_lastaccess' => 'ula', 'user' => 'u'];
+        return [
+            'user_lastaccess',
+            'user',
+        ];
     }
 
     /**

course/classes/reportbuilder/local/entities/completion.php

@@ -42,17 +42,17 @@ use stdClass;
 class completion extends base {
 
     /**
-     * Database tables that this entity uses and their default aliases
+     * Database tables that this entity uses
      *
-     * @return array
+     * @return string[]
      */
-    protected function get_default_table_aliases(): array {
+    protected function get_default_tables(): array {
         return [
-            'course_completion' => 'ccomp',
+            'course_completion',
-            'course' => 'c',
+            'course',
-            'grade_grades' => 'gg',
+            'grade_grades' ,
-            'grade_items' => 'gi',
+            'grade_items',
-            'user' => 'u',
+            'user',
         ];
     }
 

course/classes/reportbuilder/local/entities/course_category.php

@@ -40,14 +40,14 @@ use core_reportbuilder\local\report\filter;
 class course_category extends base {
 
     /**
-     * Database tables that this entity uses and their default aliases
+     * Database tables that this entity uses
      *
-     * @return array
+     * @return string[]
      */
-    protected function get_default_table_aliases(): array {
+    protected function get_default_tables(): array {
         return [
-            'context' => 'ccctx',
+            'context',
-            'course_categories' => 'cc',
+            'course_categories',
         ];
     }
 

course/classes/reportbuilder/local/entities/enrolment.php

@@ -42,12 +42,15 @@ use stdClass;
 class enrolment extends base {
 
     /**
-     * Database tables that this entity uses and their default aliases
+     * Database tables that this entity uses
      *
-     * @return array
+     * @return string[]
      */
-    protected function get_default_table_aliases(): array {
+    protected function get_default_tables(): array {
-        return ['user_enrolments' => 'ue', 'enrol' => 'e'];
+        return [
+            'user_enrolments',
+            'enrol',
+        ];
     }
 
     /**

enrol/classes/reportbuilder/local/entities/enrol.php

@@ -34,13 +34,13 @@ use core_reportbuilder\local\report\{column, filter};
 class enrol extends base {
 
     /**
-     * Database tables that this entity uses and their default aliases
+     * Database tables that this entity uses
      *
-     * @return array
+     * @return string[]
      */
-    protected function get_default_table_aliases(): array {
+    protected function get_default_tables(): array {
         return [
-            'enrol' => 'e',
+            'enrol',
         ];
     }
 

files/classes/reportbuilder/local/entities/file.php

@@ -41,14 +41,14 @@ use core_reportbuilder\local\report\{column, filter};
 class file extends base {
 
     /**
-     * Database tables that this entity uses and their default aliases
+     * Database tables that this entity uses
      *
-     * @return array
+     * @return string[]
      */
-    protected function get_default_table_aliases(): array {
+    protected function get_default_tables(): array {
         return [
-            'files' => 'f',
+            'files',
-            'context' => 'fctx',
+            'context',
         ];
     }
 

grade/report/summary/classes/local/entities/grade_items.php

@@ -59,12 +59,14 @@ class grade_items extends base {
     }
 
     /**
-     * Database tables that this entity uses and their default aliases
+     * Database tables that this entity uses
      *
-     * @return array
+     * @return string[]
      */
-    protected function get_default_table_aliases(): array {
+    protected function get_default_tables(): array {
-        return ['grade_items' => 'gi'];
+        return [
+            'grade_items',
+        ];
     }
 
     /**

group/classes/reportbuilder/local/entities/group.php

@@ -44,14 +44,14 @@ require_once("{$CFG->libdir}/grouplib.php");
 class group extends base {
 
     /**
-     * Database tables that this entity uses and their default aliases
+     * Database tables that this entity uses
      *
-     * @return array
+     * @return string[]
      */
-    protected function get_default_table_aliases(): array {
+    protected function get_default_tables(): array {
         return [
-            'context' => 'gctx',
+            'context',
-            'groups' => 'g',
+            'groups',
         ];
     }
 

group/classes/reportbuilder/local/entities/group_member.php

@@ -34,13 +34,13 @@ use core_reportbuilder\local\report\{column, filter};
 class group_member extends base {
 
     /**
-     * Database tables that this entity uses and their default aliases
+     * Database tables that this entity uses
      *
-     * @return array
+     * @return string[]
      */
-    protected function get_default_table_aliases(): array {
+    protected function get_default_tables(): array {
         return [
-            'groups_members' => 'gm',
+            'groups_members',
         ];
     }
 

group/classes/reportbuilder/local/entities/grouping.php

@@ -37,14 +37,14 @@ use core_reportbuilder\local\report\{column, filter};
 class grouping extends base {
 
     /**
-     * Database tables that this entity uses and their default aliases
+     * Database tables that this entity uses
      *
-     * @return array
+     * @return string[]
      */
-    protected function get_default_table_aliases(): array {
+    protected function get_default_tables(): array {
         return [
-            'context' => 'ggctx',
+            'context',
-            'groupings' => 'gg',
+            'groupings',
         ];
     }
 

lib/classes/reportbuilder/local/entities/context.php

@@ -36,12 +36,14 @@ use stdClass;
 class context extends base {
 
     /**
-     * Database tables that this entity uses and their default aliases
+     * Database tables that this entity uses
      *
-     * @return array
+     * @return string[]
      */
-    protected function get_default_table_aliases(): array {
+    protected function get_default_tables(): array {
-        return ['context' => 'ctx'];
+        return [
+            'context',
+        ];
     }
 
     /**

mod/lti/classes/reportbuilder/local/entities/tool_types.php

@@ -35,12 +35,15 @@ use core_reportbuilder\local\report\filter;
 class tool_types extends base {
 
     /**
-     * Database tables that this entity uses and their default aliases
+     * Database tables that this entity uses
      *
-     * @return array
+     * @return string[]
      */
-    protected function get_default_table_aliases(): array {
+    protected function get_default_tables(): array {
-        return ['lti_types' => 'tt', 'lti' => 'ti'];
+        return [
+            'lti_types',
+            'lti',
+        ];
     }
 
     /**

notes/classes/reportbuilder/local/entities/note.php

@@ -40,12 +40,14 @@ require_once("{$CFG->dirroot}/notes/lib.php");
 class note extends base {
 
     /**
-     * Database tables that this entity uses and their default aliases
+     * Database tables that this entity uses
      *
-     * @return array
+     * @return string[]
      */
-    protected function get_default_table_aliases(): array {
+    protected function get_default_tables(): array {
-        return ['post' => 'np'];
+        return [
+            'post',
+        ];
     }
 
     /**

report/configlog/classes/reportbuilder/local/entities/config_change.php

@@ -36,12 +36,14 @@ use core_reportbuilder\local\filters\text;
 class config_change extends base {
 
     /**
-     * Database tables that this entity uses and their default aliases
+     * Database tables that this entity uses
      *
-     * @return array
+     * @return string[]
      */
-    protected function get_default_table_aliases(): array {
+    protected function get_default_tables(): array {
-        return ['config_log' => 'cl'];
+        return [
+            'config_log',
+        ];
     }
 
     /**

reportbuilder/classes/local/entities/course.php

@@ -50,16 +50,16 @@ require_once($CFG->dirroot . '/course/lib.php');
 class course extends base {
 
     /**
-     * Database tables that this entity uses and their default aliases.
+     * Database tables that this entity uses
      *
-     * @return array
+     * @return string[]
      */
-    protected function get_default_table_aliases(): array {
+    protected function get_default_tables(): array {
         return [
-            'course' => 'c',
+            'course',
-            'context' => 'cctx',
+            'context',
-            'tag_instance' => 'cti',
+            'tag_instance',
-            'tag' => 'ct',
+            'tag',
         ];
     }
 

reportbuilder/classes/local/entities/user.php

@@ -50,16 +50,16 @@ use core_reportbuilder\local\report\filter;
 class user extends base {
 
     /**
-     * Database tables that this entity uses and their default aliases
+     * Database tables that this entity uses
      *
-     * @return array
+     * @return string[]
      */
-    protected function get_default_table_aliases(): array {
+    protected function get_default_tables(): array {
         return [
-            'user' => 'u',
+            'user',
-            'context' => 'uctx',
+            'context',
-            'tag_instance' => 'uti',
+            'tag_instance',
-            'tag' => 'ut',
+            'tag',
         ];
     }
 

tag/classes/reportbuilder/local/entities/collection.php

@@ -36,12 +36,14 @@ use core_reportbuilder\local\report\{column, filter};
 class collection extends base {
 
     /**
-     * Database tables that this entity uses and their default aliases
+     * Database tables that this entity uses
      *
-     * @return array
+     * @return string[]
      */
-    protected function get_default_table_aliases(): array {
+    protected function get_default_tables(): array {
-        return ['tag_coll' => 'tc'];
+        return [
+            'tag_coll',
+        ];
     }
 
     /**

tag/classes/reportbuilder/local/entities/instance.php

@@ -40,14 +40,14 @@ use core_reportbuilder\local\report\{column, filter};
 class instance extends base {
 
     /**
-     * Database tables that this entity uses and their default aliases
+     * Database tables that this entity uses
      *
-     * @return array
+     * @return string[]
      */
-    protected function get_default_table_aliases(): array {
+    protected function get_default_tables(): array {
         return [
-            'tag_instance' => 'ti',
+            'tag_instance',
-            'context' => 'tictx',
+            'context',
         ];
     }
 

tag/classes/reportbuilder/local/entities/tag.php

@@ -38,12 +38,14 @@ use core_reportbuilder\local\report\{column, filter};
 class tag extends base {
 
     /**
-     * Database tables that this entity uses and their default aliases
+     * Database tables that this entity uses
      *
-     * @return array
+     * @return string[]
      */
-    protected function get_default_table_aliases(): array {
+    protected function get_default_tables(): array {
-        return ['tag' => 't'];
+        return [
+            'tag',
+        ];
     }
 
     /**