mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-13 20:42:22 +02:00
Code Issues Projects Releases Wiki Activity

MDL-72527 core: Fix behat unit test failure

Browse Source 
$CFG->behat_wwwroot, $CFG->behat_dataroot and $CFG->behat_prefix being
undefined resulted in unit test failure.
This commit is contained in:
Matt Clarkson 2021-09-08 14:38:34 +12:00
parent 1d700796ca
commit 728e8c4a3c
2 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/phpunit/bootstrap.php
View File

@ -184,7 +184,7 @@ $allowed = array('wwwroot', 'dataroot', 'dirroot', 'admin', 'directorypermission
$productioncfg = (array)$CFG;
$CFG = new stdClass();
foreach ($productioncfg as $key=>$value) {
if (!in_array($key, $allowed) and strpos($key, 'phpunit_') !== 0) {
if (!in_array($key, $allowed) and strpos($key, 'phpunit_') !== 0 and strpos($key, 'behat_') !== 0) {
// ignore
continue;
}

16
lib/tests/behat_lib_test.php
View File

@ -32,6 +32,22 @@
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class behat_lib_test extends advanced_testcase {
/**
* Setup function
*
* Skip these tests if behat is not configured.
*
* @return void
*/
public function setUp(): void {
global $CFG;
if (empty($CFG->behat_wwwroot) || empty($CFG->behat_dataroot) || empty($CFG->behat_prefix)) {
$this->markTestSkipped('Behat not configured');
}
}
/**
* Tests for behat_is_requested_url() function.
*