mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-03-14 04:30:15 +01:00
Code Issues Projects Releases Wiki Activity

MDL-73902 theme_boost: prevent dropdowns being cut off

Browse Source
This commit is contained in:
Bas Brands 2022-03-01 13:29:12 +01:00
parent 9cd77c4130
commit 729ae8f096
3 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
admin/tool/admin_presets/tests/behat/delete.feature
View File

@ -14,8 +14,10 @@ Feature: Admin preset deletion
And I should see "Custom preset"
When I open the action menu in "Custom preset" "table_row"
And I should see "Delete"
And I press the escape key
And I open the action menu in "Full" "table_row"
Then I should not see "Delete"
And I press the escape key
And I open the action menu in "Starter" "table_row"
And I should not see "Delete"

2
lib/templates/action_menu_trigger.mustache
View File

@ -79,7 +79,7 @@
}
}}
<div class="dropdown{{^secondary.items}} hidden{{/secondary.items}}">
<a href="#" tabindex="0" class="{{triggerextraclasses}} dropdown-toggle icon-no-margin" id="action-menu-toggle-{{instance}}" aria-label="{{title}}" data-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false" aria-controls="action-menu-{{instance}}-menu" data-display="static">
<a href="#" tabindex="0" class="{{triggerextraclasses}} dropdown-toggle icon-no-margin" id="action-menu-toggle-{{instance}}" aria-label="{{title}}" data-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false" aria-controls="action-menu-{{instance}}-menu">
{{{actiontext}}}
{{{menutrigger}}}
{{#icon}}

2
reportbuilder/classes/table/base_report_table.php
View File

@ -262,7 +262,7 @@ abstract class base_report_table extends table_sql implements dynamic, renderabl
$this->wrap_html_start();
echo html_writer::start_tag('div', ['class' => 'no-overflow']);
echo html_writer::start_tag('div');
echo html_writer::start_tag('table', $this->attributes);
}
}