mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-17 21:49:15 +01:00
Code Issues Projects Releases Wiki Activity

MDL-81458 question: Cast the fraction value to a float

Browse Source 
When retrieving the answer data from the database, it's essential to
cast the value of the answer's fraction to a float before storing it
into the question object. This step is crucial for ensuring consistency,
as some database engines return floats as strings like '1.0000000'.
This commit is contained in:
Mihail Geshoski 2024-04-09 00:34:39 +08:00
parent b621a7e4b3
commit 72e9a1bbd9
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
question/type/questiontypebase.php
View File

@ -931,13 +931,13 @@ class question_type {
if (is_array($extraanswerfields)) {
$answerextensiontable = array_shift($extraanswerfields);
// Use LEFT JOIN in case not every answer has extra data.
$question->options->answers = $DB->get_records_sql("
$answers = $DB->get_records_sql("
SELECT qa.*, qax." . implode(', qax.', $extraanswerfields) . '
FROM {question_answers} qa ' . "
LEFT JOIN {{$answerextensiontable}} qax ON qa.id = qax.answerid
WHERE qa.question = ?
ORDER BY qa.id", array($question->id));
if (!$question->options->answers) {
if (!$answers) {
echo $OUTPUT->notification('Failed to load question answers from the table ' .
$answerextensiontable . 'for questionid ' . $question->id);
return false;
@ -945,9 +945,15 @@ class question_type {
} else {
// Don't check for success or failure because some question types do
// not use the answers table.
$question->options->answers = $DB->get_records('question_answers',
$answers = $DB->get_records('question_answers',
array('question' => $question->id), 'id ASC');
}
// Store the answers into the question object.
$question->options->answers = array_map(function($answer) {
// Some database engines return floats as strings like '1.0000000'. Cast to float for consistency.
$answer->fraction = (float) $answer->fraction;
return $answer;
}, $answers);
$question->hints = $DB->get_records('question_hints',
array('questionid' => $question->id), 'id ASC');