From 72eaa3c9168bfc1115f3e58d301c6f80b131be7e Mon Sep 17 00:00:00 2001
From: JayChurchward <jay@churchward.ca>
Date: Thu, 30 Jan 2020 15:01:24 -0500
Subject: [PATCH] MDL-67696 mod_forum: Changed invalid count() to loop counter.
---
mod/forum/classes/task/refresh_forum_post_counts.php | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/mod/forum/classes/task/refresh_forum_post_counts.php b/mod/forum/classes/task/refresh_forum_post_counts.php
index 7a018af7de0..9ae7eb24d37 100644
--- a/mod/forum/classes/task/refresh_forum_post_counts.php
+++ b/mod/forum/classes/task/refresh_forum_post_counts.php
@@ -54,9 +54,12 @@ class refresh_forum_post_counts extends \core\task\adhoc_task {
protected function update_null_forum_post_counts(): bool {
global $CFG, $DB;
- // Default to chunks of 5000 records per run, unless overridden in config.php
+ // Default to chunks of 5000 records per run, unless overridden in config.php.
$chunksize = $CFG->forumpostcountchunksize ?? 5000;
+ // Initialize counter.
+ $recordscount = 0;
+
$select = 'wordcount IS NULL OR charcount IS NULL';
$recordset = $DB->get_recordset_select('forum_posts', $select, null, 'discussion', 'id, message', 0, $chunksize);
@@ -68,9 +71,9 @@ class refresh_forum_post_counts extends \core\task\adhoc_task {
foreach ($recordset as $record) {
\mod_forum\local\entities\post::add_message_counts($record);
$DB->update_record('forum_posts', $record);
+ $recordscount++;
}
- $recordscount = count($recordset);
$recordset->close();
return ($recordscount == $chunksize);