mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-02-24 20:13:14 +01:00
Code Issues Projects Releases Wiki Activity

Merge branch 'MDL-79020-main' of https://github.com/ferranrecio/moodle

Browse Source
This commit is contained in:
Huong Nguyen 2024-09-11 09:19:04 +07:00
commit 74b0fc8034
No known key found for this signature in database
GPG Key ID: 40D88AB693A3E72A
2 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
course/format/templates/local/content/cm/completion_dialog.mustache
View File

@ -110,7 +110,7 @@
{{! Show edit link to editing teachers. }}
{{#editing}}
{{#editurl}}
<div class="editcompletion border-top mt-3 pt-3">
<div class="editcompletion bulk-hidden border-top mt-3 pt-3">
<a href="{{editurl}}" class="btn btn-sm px-2 py-0">
{{#hasconditions}}{{#pix}} i/edit, core {{/pix}}{{#str}}editconditions, completion{{/str}}{{/hasconditions}}
{{^hasconditions}}{{#pix}} t/add, core {{/pix}}{{#str}}addconditions, completion{{/str}}{{/hasconditions}}

16
course/format/tests/behat/coursepage_completion.feature
View File

@ -174,3 +174,19 @@ Feature: Course page activities completion
# Student view.
And I am on the "C1" "Course" page logged in as "student1"
And "There are no completion conditions set for this activity." "text" should exist in the "Activity sample" "core_courseformat > Activity completion"
@javascript
Scenario: Completion edit button should be hidden in bulk editing
Given the following "activity" exists:
| activity | assign |
| name | Activity sample |
| course | C1 |
| completion | 2 |
| completionview | 1 |
And I log in as "teacher1"
And I am on "C1" course homepage with editing mode on
And I click on "Completion" "button"
And "Edit conditions" "link" in the "Activity sample" "activity" should be visible
When I click on "Bulk actions" "button"
And I click on "Completion" "button"
Then "Edit conditions" "link" in the "Activity sample" "activity" should not be visible