mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-02-15 21:36:58 +01:00
Code Issues Projects Releases Wiki Activity

Petr's review: Removing assignment by reference

Browse Source
This commit is contained in:
David Mudrak 2010-01-04 17:52:45 +00:00
parent 2fe703edfc
commit 74e28b263a
4 changed files with 12 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
mod/workshop/allocation/manual/allocator.php
View File

@ -132,6 +132,7 @@ class workshop_manual_allocator implements workshop_allocator {
*/
public function ui(moodle_mod_workshop_renderer $wsoutput) {
global $PAGE;
global $CFG; // bacause we include other libs here
$hlauthorid = -1; // highlight this author
$hlreviewerid = -1; // highlight this reviewer

4
mod/workshop/allocation/random/settings_form.php
View File

@ -64,9 +64,9 @@ class workshop_random_allocator_form extends moodleform {
$options_numper = array(WORKSHOP_USERTYPE_AUTHOR => get_string('numperauthor', 'workshop'),
WORKSHOP_USERTYPE_REVIEWER => get_string('numperreviewer', 'workshop'));
$grpnumofreviews = array();
$grpnumofreviews[] =& $mform->createElement('select', 'numofreviews', '', $options_numofreviewes);
$grpnumofreviews[] = $mform->createElement('select', 'numofreviews', '', $options_numofreviewes);
$mform->setDefault('numofreviews', 4);
$grpnumofreviews[] =& $mform->createElement('select', 'numper', '', $options_numper);
$grpnumofreviews[] = $mform->createElement('select', 'numper', '', $options_numper);
$mform->setDefault('numper', WORKSHOP_USERTYPE_AUTHOR);
$mform->addGroup($grpnumofreviews, 'grpnumofreviews', get_string('numofreviews', 'workshop'), array(' '), false);

16
mod/workshop/grading/noerrors/edit_form.php
View File

@ -48,14 +48,14 @@ class workshop_edit_noerrors_strategy_form extends workshop_edit_strategy_form {
$weights = workshop_get_dimension_weights();
$repeated = array();
$repeated[] =& $mform->createElement('hidden', 'dimensionid', 0);
$repeated[] =& $mform->createElement('header', 'dimension',
$repeated[] = $mform->createElement('hidden', 'dimensionid', 0);
$repeated[] = $mform->createElement('header', 'dimension',
get_string('dimensionnumbernoerrors', 'workshop', '{no}'));
$repeated[] =& $mform->createElement('htmleditor', 'description',
$repeated[] = $mform->createElement('htmleditor', 'description',
get_string('dimensiondescription', 'workshop'), array());
$repeated[] =& $mform->createElement('text', 'grade0', get_string('noerrorsgrade0', 'workshop'), array('size'=>'15'));
$repeated[] =& $mform->createElement('text', 'grade1', get_string('noerrorsgrade1', 'workshop'), array('size'=>'15'));
$repeated[] =& $mform->createElement('select', 'weight', get_string('dimensionweight', 'workshop'), $weights);
$repeated[] = $mform->createElement('text', 'grade0', get_string('noerrorsgrade0', 'workshop'), array('size'=>'15'));
$repeated[] = $mform->createElement('text', 'grade1', get_string('noerrorsgrade1', 'workshop'), array('size'=>'15'));
$repeated[] = $mform->createElement('select', 'weight', get_string('dimensionweight', 'workshop'), $weights);
$repeatedoptions = array();
$repeatedoptions['description']['type'] = PARAM_CLEANHTML;
@ -86,8 +86,8 @@ class workshop_edit_noerrors_strategy_form extends workshop_edit_strategy_form {
$mform->addElement('hidden', 'map[0]', 100);
for ($i = 1; $i <= $numofdisplaydimensions; $i++) {
$selects = array();
$selects[] =& $mform->createElement('select', "map[$i]", $i, $percents);
$selects[] =& $mform->createElement('static', "mapdefault[$i]", '',
$selects[] = $mform->createElement('select', "map[$i]", $i, $percents);
$selects[] = $mform->createElement('static', "mapdefault[$i]", '',
get_string('percents', 'workshop', floor(100 - $i * 100 / $numofdisplaydimensions)));
$mform->addGroup($selects, "grademapping$i", $i, array(' '), false);
$mform->setDefault("map[$i]", '');

2
mod/workshop/mod_form.php
View File

@ -37,7 +37,7 @@ class mod_workshop_mod_form extends moodleform_mod {
global $CFG, $COURSE;
$workshopconfig = get_config('workshop');
$mform =& $this->_form;
$mform = $this->_form;
/// General --------------------------------------------------------------------
$mform->addElement('header', 'general', get_string('general', 'form'));