From 771a8c3c95661615e6e2b8e9a9b0b35b5b84aceb Mon Sep 17 00:00:00 2001 From: Andrew Nicols Date: Thu, 7 Mar 2019 17:30:31 +0800 Subject: [PATCH] MDL-64883 mod_chat: Fix SQL in cron --- mod/chat/classes/task/cron_task.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mod/chat/classes/task/cron_task.php b/mod/chat/classes/task/cron_task.php index d174941a1fb..f933c83dabc 100644 --- a/mod/chat/classes/task/cron_task.php +++ b/mod/chat/classes/task/cron_task.php @@ -57,8 +57,8 @@ class cron_task extends \core\task\scheduled_task { $subselect = "SELECT c.keepdays FROM {chat} c WHERE c.id = {chat_messages}.chatid"; - $DB->delete_records_select('chat_messages', "($subselect) > 0 AND timestamp < ?", - [$timenow - ($subselect) * DAYSECS]); + $DB->delete_records_select('chat_messages', "($subselect) > 0 AND timestamp < (? - ($subselect) * ?)", + [$timenow, DAYSECS]); $DB->delete_records_select('chat_messages_current', "timestamp < ?", [$timenow - 8 * HOURSECS]); }