From 77a827e14df8e0a0ac3497790d4a02d11f6d4219 Mon Sep 17 00:00:00 2001 From: Sam Chaffee Date: Tue, 20 May 2014 10:44:46 -0600 Subject: [PATCH] MDL-37168 mod_lti: Fix LTI activity quick edit title --- mod/lti/lib.php | 19 +++++++++++++++++++ mod/lti/servicelib.php | 1 + mod/lti/tests/generator/lib.php | 3 +++ 3 files changed, 23 insertions(+) diff --git a/mod/lti/lib.php b/mod/lti/lib.php index 5603817f49b..93260276177 100644 --- a/mod/lti/lib.php +++ b/mod/lti/lib.php @@ -102,6 +102,9 @@ function lti_add_instance($lti, $mform) { $lti->timecreated = time(); $lti->timemodified = $lti->timecreated; $lti->servicesalt = uniqid('', true); + if (!isset($lti->typeid)) { + $lti->typeid = null; + } lti_force_type_config_settings($lti, lti_get_type_config_by_instance($lti)); @@ -501,6 +504,22 @@ function lti_grade_item_update($basiclti, $grades = null) { return grade_update('mod/lti', $basiclti->course, 'mod', 'lti', $basiclti->id, 0, $grades, $params); } +/** + * Update activity grades + * + * @param stdClass $basiclti The LTI instance + * @param int $userid Specific user only, 0 means all. + * @param bool $nullifnone Not used + */ +function lti_update_grades($basiclti, $userid=0, $nullifnone=true) { + global $CFG; + require_once($CFG->dirroot.'/mod/lti/servicelib.php'); + // LTI doesn't have its own grade table so the only thing to do is update the grade item. + if (lti_accepts_grades($basiclti)) { + lti_grade_item_update($basiclti); + } +} + /** * Delete grade item for given basiclti * diff --git a/mod/lti/servicelib.php b/mod/lti/servicelib.php index b6d4e469601..88ebdb1c49a 100644 --- a/mod/lti/servicelib.php +++ b/mod/lti/servicelib.php @@ -26,6 +26,7 @@ defined('MOODLE_INTERNAL') || die; require_once($CFG->dirroot.'/mod/lti/OAuthBody.php'); +require_once($CFG->dirroot.'/mod/lti/locallib.php'); // TODO: Switch to core oauthlib once implemented - MDL-30149. use moodle\mod\lti as lti; diff --git a/mod/lti/tests/generator/lib.php b/mod/lti/tests/generator/lib.php index a8963284c04..aedcd4b700b 100644 --- a/mod/lti/tests/generator/lib.php +++ b/mod/lti/tests/generator/lib.php @@ -61,6 +61,9 @@ class mod_lti_generator extends testing_module_generator { if (!isset($record->instructorchoiceacceptgrades)) { $record->instructorchoiceacceptgrades = 1; } + if (!isset($record->typeid)) { + $record->typeid = null; + } return parent::create_instance($record, (array)$options); } }