From 77baa12643f165468ef1f2861234ce7de4d84a68 Mon Sep 17 00:00:00 2001 From: Shamim Rezaie Date: Sun, 22 Nov 2020 21:22:55 +1100 Subject: [PATCH] MDL-64982 behat: Remove deprecated behat timeout constants Behat timeout constants behat_base::TIMEOUT, EXTENDED_TIMEOUT, and REDUCED_TIMEOUT, which were deprecated in 3.7, have been removed. --- lib/behat/classes/behat_session_interface.php | 31 ------------------- lib/upgrade.txt | 1 + 2 files changed, 1 insertion(+), 31 deletions(-) diff --git a/lib/behat/classes/behat_session_interface.php b/lib/behat/classes/behat_session_interface.php index 2746070974c..7f2dd0c29e6 100644 --- a/lib/behat/classes/behat_session_interface.php +++ b/lib/behat/classes/behat_session_interface.php @@ -37,37 +37,6 @@ * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later */ interface behat_session_interface { - /** - * Small timeout. - * - * A reduced timeout for cases where self::TIMEOUT is too much - * and a simple $this->getSession()->getPage()->find() could not - * be enough. - * - * @deprecated since Moodle 3.7 MDL-64979 - please use get_reduced_timeout() instead - * @todo MDL-64982 This will be deleted in Moodle 3.11 - * @see behat_base::get_reduced_timeout() - */ - const REDUCED_TIMEOUT = 2; - - /** - * The timeout for each Behat step (load page, wait for an element to load...). - * - * @deprecated since Moodle 3.7 MDL-64979 - please use get_timeout() instead - * @todo MDL-64982 This will be deleted in Moodle 3.11 - * @see behat_base::get_timeout() - */ - const TIMEOUT = 6; - - /** - * And extended timeout for specific cases. - * - * @deprecated since Moodle 3.7 MDL-64979 - please use get_extended_timeout() instead - * @todo MDL-64982 This will be deleted in Moodle 3.11 - * @see behat_base::get_extended_timeout() - */ - const EXTENDED_TIMEOUT = 10; - /** * The JS code to check that the page is ready. * diff --git a/lib/upgrade.txt b/lib/upgrade.txt index ab7b3a57d9a..f17f974debe 100644 --- a/lib/upgrade.txt +++ b/lib/upgrade.txt @@ -5,6 +5,7 @@ information provided here is intended especially for developers. * New optional parameter $extracontent for print_collapsible_region_start(). This allows developers to add interactive HTML elements (e.g. a help icon) after the collapsible region's toggle link. * Final deprecation i_dock_block() in behat_deprecated.php +* Behat timeout constants behat_base::TIMEOUT, EXTENDED_TIMEOUT, and REDUCED_TIMEOUT, which were deprecated in 3.7, have been removed. === 3.10 === * PHPUnit has been upgraded to 8.5. That comes with a few changes: