MDL-79781 course: detect invalid creator role for pending courses.

This commit is contained in:
Paul Holden 2023-10-26 13:16:22 +01:00
parent d76e211be6
commit 78b841dcd2
No known key found for this signature in database
GPG Key ID: A81A96D6045F6164
2 changed files with 9 additions and 2 deletions

View File

@ -110,8 +110,14 @@ if (empty($pending)) {
echo $OUTPUT->heading(get_string('nopendingcourses'));
} else {
echo $OUTPUT->heading(get_string('coursespending'));
$role = $DB->get_record('role', array('id' => $CFG->creatornewroleid), '*', MUST_EXIST);
echo $OUTPUT->notification(get_string('courserequestwarning', 'core', role_get_name($role)), 'notifyproblem');
$role = $DB->get_record('role', ['id' => $CFG->creatornewroleid]);
if ($role) {
echo $OUTPUT->notification(get_string('courserequestwarning', 'core', role_get_name($role)), 'notifyproblem');
} else {
$userpoliciesurl = new moodle_url('/admin/settings.php', ['section' => 'userpolicies']);
echo $OUTPUT->notification(get_string('courserequestroleerror', 'core', (string) $userpoliciesurl), 'notifyerror');
}
/// Build a table of all the requests.
$table = new html_table();

View File

@ -413,6 +413,7 @@ $string['courserequestdetails'] = 'Details of the course you are requesting';
$string['courserequestfailed'] = 'For some reason, your course request could not be saved';
$string['courserequestintro'] = 'Use this form to request a course to be created for you.<br />Try and fill in as much information as you can to allow<br />the administrators to understand your reasons for wanting this course.';
$string['courserequestreason'] = 'Reasons for wanting this course';
$string['courserequestroleerror'] = 'The creators\' role in new courses configuration is invalid. Please see <a href="{$a}">user policies</a>.';
$string['courserequestsuccess'] = 'Your course request has been saved successfully. You will be sent an email to inform you whether your request was approved.';
$string['courserequestsupport'] = 'Supporting information to help the administrator evaluate this request';
$string['courserequestwarning'] = 'The user requesting this course will be automatically enrolled and assigned the role of {$a}.';