mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-03-24 09:30:17 +01:00
Code Issues Projects Releases Wiki Activity

MDL-68200 mod_forum: remove address tags

Browse Source 
Reasons:
- The element “h4” must not appear as a descendant of the “address” element
- This element should not contain more information than the contact
information, like a publication date (which belongs in a <time> element)
 element)
This commit is contained in:
Shamim Rezaie 2020-03-26 17:24:17 +11:00
parent 9f2a68feb4
commit 79364d4cdc
3 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
mod/forum/templates/forum_discussion_nested_v2_first_post.mustache
View File

@ -77,7 +77,7 @@
<header id="post-header-{{id}}-{{uniqid}}">
{{^isdeleted}}
<div class="d-flex flex-wrap align-items-center mb-1">
<address class="mb-0 mr-2" tabindex="-1">
<div class="mr-2" tabindex="-1">
{{#author}}
<h4 class="h6 d-lg-inline-block mb-0 author-header mr-1">
{{#parentauthorname}}
@ -108,7 +108,7 @@
<time class="text-muted">
{{#userdate}} {{timecreated}}, {{#str}} strftimerecentfull, core_langconfig {{/str}} {{/userdate}}
</time>
</address>
</div>
<div class="d-flex align-items-center ml-auto">
{{#author.groups}}

4
mod/forum/templates/forum_discussion_post.mustache
View File

@ -76,14 +76,14 @@
}}>{{$subject}}{{{subject}}}{{/subject}}</h3>
{{/subjectheading}}
{{^isdeleted}}
<address tabindex="-1">
<div class="mb-3" tabindex="-1">
{{#html.authorsubheading}}{{{.}}}{{/html.authorsubheading}}
{{^html.authorsubheading}}
<time>
{{#userdate}} {{timecreated}}, {{#str}} strftimedaydatetime, core_langconfig {{/str}} {{/userdate}}
</time>
{{/html.authorsubheading}}
</address>
</div>
{{/isdeleted}}
{{#isprivatereply}}
<div class="privatereplyinfo">

4
mod/forum/templates/forum_discussion_threaded_post.mustache
View File

@ -38,9 +38,7 @@
>
<a href="{{{urls.viewisolated}}}">{{subject}}</a>
{{^isdeleted}}
<address class="d-inline-block mb-0">
{{{html.authorsubheading}}}
</address>
{{{html.authorsubheading}}}
{{/isdeleted}}
<div data-region="replies-container">