mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-16 14:02:32 +02:00
Code Issues Projects Releases Wiki Activity

MDL-76971 reportbuilder: switch remaining classes to external_api.

Browse Source 
Continues on the work started in a3cc26f8, to remove the last
remnants of usage of previous external API classes.
This commit is contained in:
Paul Holden 2023-01-20 11:05:15 +00:00
parent 4e632b7251
commit 7c7024af31
No known key found for this signature in database
GPG Key ID: A81A96D6045F6164
6 changed files with 13 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
reportbuilder/classes/output/audience_heading_editable.php
View File

@ -18,17 +18,12 @@ declare(strict_types=1);
namespace core_reportbuilder\output;
use core_external;
use core\output\inplace_editable;
use core_external\external_api;
use core_reportbuilder\permission;
use core_reportbuilder\local\audiences\base;
use core_reportbuilder\local\models\audience;
defined('MOODLE_INTERNAL') || die;
global $CFG;
require_once("{$CFG->libdir}/external/externallib.php");
/**
* Audience heading editable component
*
@ -77,7 +72,7 @@ class audience_heading_editable extends inplace_editable {
$report = $audience->get_report();
core_external::validate_context($report->get_context());
external_api::validate_context($report->get_context());
permission::require_can_edit_report($report);
$value = clean_param($value, PARAM_TEXT);

9
reportbuilder/classes/output/column_aggregation_editable.php
View File

@ -18,18 +18,13 @@ declare(strict_types=1);
namespace core_reportbuilder\output;
use core_external;
use core\output\inplace_editable;
use core_external\external_api;
use core_reportbuilder\manager;
use core_reportbuilder\permission;
use core_reportbuilder\local\helpers\aggregation;
use core_reportbuilder\local\models\column;
defined('MOODLE_INTERNAL') || die;
global $CFG;
require_once("{$CFG->libdir}/external/externallib.php");
/**
* Column aggregation editable component
*
@ -81,7 +76,7 @@ class column_aggregation_editable extends inplace_editable {
$report = $column->get_report();
core_external::validate_context($report->get_context());
external_api::validate_context($report->get_context());
permission::require_can_edit_report($report);
$value = clean_param($value, PARAM_TEXT);

9
reportbuilder/classes/output/column_heading_editable.php
View File

@ -18,17 +18,12 @@ declare(strict_types=1);
namespace core_reportbuilder\output;
use core_external;
use core\output\inplace_editable;
use core_external\external_api;
use core_reportbuilder\manager;
use core_reportbuilder\permission;
use core_reportbuilder\local\models\column;
defined('MOODLE_INTERNAL') || die;
global $CFG;
require_once("{$CFG->libdir}/external/externallib.php");
/**
* Column heading editable component
*
@ -78,7 +73,7 @@ class column_heading_editable extends inplace_editable {
$report = $column->get_report();
core_external::validate_context($report->get_context());
external_api::validate_context($report->get_context());
permission::require_can_edit_report($report);
$value = clean_param($value, PARAM_TEXT);

10
reportbuilder/classes/output/filter_heading_editable.php
View File

@ -18,17 +18,12 @@ declare(strict_types=1);
namespace core_reportbuilder\output;
use core_external;
use core\output\inplace_editable;
use core_external\external_api;
use core_reportbuilder\manager;
use core_reportbuilder\permission;
use core_reportbuilder\local\models\filter;
defined('MOODLE_INTERNAL') || die;
global $CFG;
require_once("{$CFG->libdir}/external/externallib.php");
/**
* Filter heading editable component
*
@ -77,7 +72,8 @@ class filter_heading_editable extends inplace_editable {
$filter = new filter($filterid);
$report = $filter->get_report();
core_external::validate_context($report->get_context());
external_api::validate_context($report->get_context());
permission::require_can_edit_report($report);
$value = clean_param($value, PARAM_TEXT);

3
reportbuilder/classes/output/report_name_editable.php
View File

@ -21,6 +21,7 @@ namespace core_reportbuilder\output;
use html_writer;
use moodle_url;
use core\output\inplace_editable;
use core_external\external_api;
use core_reportbuilder\permission;
use core_reportbuilder\local\models\report;
@ -67,7 +68,7 @@ class report_name_editable extends inplace_editable {
public static function update(int $reportid, string $value): self {
$report = new report($reportid);
\core_external\external_api::validate_context($report->get_context());
external_api::validate_context($report->get_context());
permission::require_can_edit_report($report);
$value = trim(clean_param($value, PARAM_TEXT));

9
reportbuilder/classes/output/schedule_name_editable.php
View File

@ -18,16 +18,11 @@ declare(strict_types=1);
namespace core_reportbuilder\output;
use core_external;
use core\output\inplace_editable;
use core_external\external_api;
use core_reportbuilder\permission;
use core_reportbuilder\local\models\schedule;
defined('MOODLE_INTERNAL') || die;
global $CFG;
require_once("{$CFG->libdir}/external/externallib.php");
/**
* Schedule name editable component
*
@ -69,7 +64,7 @@ class schedule_name_editable extends inplace_editable {
$report = $schedule->get_report();
core_external::validate_context($report->get_context());
external_api::validate_context($report->get_context());
permission::require_can_edit_report($report);
$value = trim(clean_param($value, PARAM_TEXT));