mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-18 22:08:20 +01:00
Code Issues Projects Releases Wiki Activity

MDL-79962 roles: consistent sorting of role entity name column.

Browse Source 
The "name" field is typically omitted for default/pre-defined roles,
which should be accounted for when sorting.
This commit is contained in:
Paul Holden 2023-11-01 13:05:59 +00:00
parent e4d1369475
commit 7c76e9223b
No known key found for this signature in database
GPG Key ID: A81A96D6045F6164
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
admin/roles/classes/reportbuilder/local/entities/role.php
View File

@ -97,7 +97,7 @@ class role extends base {
->set_type(column::TYPE_TEXT)
->add_fields("{$rolealias}.name, {$rolealias}.shortname, {$rolealias}.id, {$contextalias}.id AS contextid")
->add_fields(context_helper::get_preload_record_columns_sql($contextalias))
->set_is_sortable(true)
->set_is_sortable(true, ["CASE WHEN {$rolealias}.name = '' THEN {$rolealias}.shortname ELSE {$rolealias}.name END"])
->set_callback(static function($name, stdClass $role): string {
if ($name === null) {
return '';