mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-16 14:02:32 +02:00
Code Issues Projects Releases Wiki Activity

Merge branch 'MDL-72060-master' of git://github.com/lameze/moodle

Browse Source
This commit is contained in:
Shamim Rezaie 2021-09-28 20:15:06 +10:00
commit 7d14aa28ae
2 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mod/lti/service/gradebookservices/classes/local/service/gradebookservices.php
View File

@ -721,7 +721,7 @@ class gradebookservices extends service_base {
$gradebookroles = explode(',', $CFG->gradebookroles);
foreach ($roles as $role) {
foreach ($gradebookroles as $gradebookrole) {
if ($role->roleid = $gradebookrole) {
if ($role->roleid === $gradebookrole) {
$gradableuser = true;
}
}

17
mod/lti/service/gradebookservices/tests/gradebookservices_test.php
View File

@ -150,6 +150,23 @@ class mod_lti_gradebookservices_testcase extends advanced_testcase {
$this->assertFalse(array_key_exists('$LineItem.url', $params));
}
/**
* Test if a user can be graded in a course.
*/
public function test_is_user_gradable_in_course() {
$this->resetAfterTest();
$generator = $this->getDataGenerator();
$course = $generator->create_course();
$user1 = $generator->create_user();
$user2 = $generator->create_user();
$generator->enrol_user($user1->id, $course->id, 'student');
$generator->enrol_user($user2->id, $course->id, 'editingteacher');
$this->assertTrue(gradebookservices::is_user_gradable_in_course($course->id, $user1->id));
$this->assertFalse(gradebookservices::is_user_gradable_in_course($course->id, $user2->id));
}
/**
* Asserts a matching gradebookservices record exist with the matching tag and resourceid.
*