mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-03-14 04:30:15 +01:00
Code Issues Projects Releases Wiki Activity

MDL-80738 quiz_statistics: ensure tests uses a DB-backed lock class.

Browse Source 
Fix the test file/class name too.

Co-authored-by: Andrew Nicols <andrew@nicols.co.uk>
This commit is contained in:
Paul Holden 2024-01-29 09:46:52 +00:00
parent f30110b5eb
commit 7db305c8f4
No known key found for this signature in database
GPG Key ID: A81A96D6045F6164
1 changed files with 20 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
mod/quiz/report/statistics/tests/test_quiz_statistics_report.php → mod/quiz/report/statistics/tests/quiz_statistics_report_test.php
View File

@ -33,7 +33,7 @@ require_once($CFG->dirroot . '/mod/quiz/tests/quiz_question_helper_test_trait.ph
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
* @covers \quiz_statistics_report
*/
class test_quiz_statistics_report extends \advanced_testcase {
class quiz_statistics_report_test extends \advanced_testcase {
use \quiz_question_helper_test_trait;
@ -56,14 +56,28 @@ class test_quiz_statistics_report extends \advanced_testcase {
*
* This allows us to create a lock in our test code that will block a lock request
* on the same key in code under test.
*
* @return void
*/
public static function setUpBeforeClass(): void {
public function setUp(): void {
global $CFG;
self::$lockdb = \moodle_database::get_driver_instance($CFG->dbtype, $CFG->dblibrary);
self::$lockdb->connect($CFG->dbhost, $CFG->dbuser, $CFG->dbpass, $CFG->dbname, $CFG->prefix, $CFG->dboptions);
$lockfactory = \core\lock\lock_config::get_lock_factory('quiz_statistics_get_stats');
$lockfactoryclass = \core\lock\lock_config::get_lock_factory_class();
$lockfactory = new $lockfactoryclass('quiz_statistics_get_stats');
// Iterate lock factory hierarchy to see if it contains a 'db' property we can use.
$reflectionclass = new \ReflectionClass($lockfactory);
while ($reflectionclass) {
if ($reflectionhasdb = $reflectionclass->hasProperty('db')) {
break;
}
$reflectionclass = $reflectionclass->getParentClass();
}
if (!$reflectionhasdb) {
$this->markTestSkipped('Test lock factory should be a db type');
}
$reflectiondb = new \ReflectionProperty($lockfactory, 'db');
$reflectiondb->setAccessible(true);
$reflectiondb->setValue($lockfactory, self::$lockdb);
@ -72,10 +86,8 @@ class test_quiz_statistics_report extends \advanced_testcase {
/**
* Dispose of the extra DB connection and lock factory.
*
* @return void
*/
public static function tearDownAfterClass(): void {
public function tearDown(): void {
self::$lockdb->dispose();
self::$lockdb = null;
self::$lockfactory = null;