mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-18 05:58:34 +01:00
Code Issues Projects Releases Wiki Activity

MDL-23922 preventing invalid modifications of PAGE object

Browse Source
This commit is contained in:
Petr Skoda 2010-08-24 13:39:13 +00:00
parent c605baf802
commit 7db8dd1ea4
1 changed files with 22 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
lib/pagelib.php
View File

@ -165,6 +165,8 @@ class moodle_page {
protected $_blockseditingcap = 'moodle/site:manageblocks';
protected $_block_actions_done = false;
protected $_othereditingcaps = array();
protected $_cacheable = true;
@ -582,15 +584,31 @@ class moodle_page {
* PHP overloading magic to make the $PAGE->course syntax work by redirecting
* it to the corresponding $PAGE->magic_get_course() method if there is one, and
* throwing an exception if not.
* @var string field name
*
* @param $name string property name
* @return mixed
*/
public function __get($field) {
$getmethod = 'magic_get_' . $field;
public function __get($name) {
$getmethod = 'magic_get_' . $name;
if (method_exists($this, $getmethod)) {
return $this->$getmethod();
} else {
throw new coding_exception('Unknown field ' . $field . ' of $PAGE.');
throw new coding_exception('Unknown property ' . $name . ' of $PAGE.');
}
}
/**
* PHP overloading magic which prevents the $PAGE->context = $context; syntax
*
* @param $name string property name
* @param $name mixed value
* @return void, throws exception if field not defined in page class
*/
public function __set($name, $value) {
if (method_exists($this, 'set_' . $name)) {
throw new coding_exception('Invalid attempt to modify page object', "Use \$PAGE->set_$name() instead.");
} else {
throw new coding_exception('Invalid attempt to modify page object', "Unknown property $name");
}
}