From b691e7b4347f122e266ff4176ae30fcfa78ff584 Mon Sep 17 00:00:00 2001 From: Cameron Ball Date: Thu, 4 Nov 2021 15:25:39 +0800 Subject: [PATCH] MDL-72992 assign: Allow gradebook to override feedback when empty --- mod/assign/locallib.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/mod/assign/locallib.php b/mod/assign/locallib.php index b7e96b05929..be8a7c072a9 100644 --- a/mod/assign/locallib.php +++ b/mod/assign/locallib.php @@ -8958,7 +8958,10 @@ class assign { if ($gradebookplugin) { $grade = $this->get_user_grade($result->userid, false); if ($grade) { - $gradebookgrade->feedback = $gradebookplugin->text_for_gradebook($grade); + $feedbacktext = $gradebookplugin->text_for_gradebook($grade); + if (!empty($feedbacktext)) { + $gradebookgrade->feedback = $feedbacktext; + } $gradebookgrade->feedbackformat = $gradebookplugin->format_for_gradebook($grade); $gradebookgrade->feedbackfiles = $gradebookplugin->files_for_gradebook($grade); }