mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-21 00:12:56 +02:00
Code Issues Projects Releases Wiki Activity

MDL-32112 horrible hack that ignores invalid size for XMLDB_TYPE_NUMBER in numerical question type

Browse Source 
The easies fix could be to use VARCHAR instead because this field is used only for reading and writing, no selects on this field it seems.
This commit is contained in:
Petr Skoda 2012-03-19 20:48:48 +01:00
parent d3232735ee
commit 7fd31fe86c
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/xmldb/xmldb_field.php
View File

@ -726,8 +726,13 @@ class xmldb_field extends xmldb_object {
break;
case XMLDB_TYPE_NUMBER:
$maxlength = 20;
if ($xmldb_table->getName() === 'question_numerical_units' and $name === 'multiplier') {
//TODO: remove after MDL-32113 is resolved
$maxlength = 40;
}
$length = $this->getLength();
if (!is_number($length) or $length <= 0 or $length > 20) {
if (!is_number($length) or $length <= 0 or $length > $maxlength) {
return 'Invalid field definition in table {'.$xmldb_table->getName(). '}: XMLDB_TYPE_NUMBER field "'.$this->getName().'" has invalid length';
}
$decimals = $this->getDecimals();