mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-14 04:52:36 +02:00
Code Issues Projects Releases Wiki Activity

MDL-70173 theme_boost: Fix empty link issue on the "Go to top" button

Browse Source 
On behat, we have to use a more specific test step if we are looking
for a "Go" button on a modal. The reason is that the html of the modal
content is put after the html of the "Go to top" button, so behat
may find the "Go to top" button if we just look for "Go".
This commit is contained in:
Shamim Rezaie 2020-12-08 05:00:27 +11:00
parent 97b0401443
commit 805df4f846
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
mod/quiz/tests/behat/editing_add.feature
View File

@ -77,7 +77,7 @@ Feature: Edit quiz page - adding things
When I press "Repaginate"
Then I should see "Repaginate with"
And I set the field "menuquestionsperpage" to "2"
When I press "Go"
When I click on "Go" "button" in the "Repaginate" "dialogue"
And I should see "Essay 01 new" on quiz page "1"
And I should see "Essay 02 new" on quiz page "1"
And I should see "Essay 03 new" on quiz page "2"
@ -231,7 +231,7 @@ Feature: Edit quiz page - adding things
When I press "Repaginate"
Then I should see "Repaginate with"
And I set the field "menuquestionsperpage" to "1"
When I press "Go"
When I click on "Go" "button" in the "Repaginate" "dialogue"
And I should see "Essay 03" on quiz page "1"
And I should see "Essay 01" on quiz page "2"
And I should see "Essay 02" on quiz page "3"

6
mod/quiz/tests/behat/editing_repaginate.feature
View File

@ -107,7 +107,7 @@ Feature: Edit quiz page - pagination
# Repaginate one question per page.
When I press "Repaginate"
And I set the field "menuquestionsperpage" to "1"
And I press "Go"
And I click on "Go" "button" in the "Repaginate" "dialogue"
Then I should see "Essay 01 new" on quiz page "1"
And I should see "Essay 02 new" on quiz page "2"
And I should see "Essay 03 new" on quiz page "3"
@ -136,7 +136,7 @@ Feature: Edit quiz page - pagination
# Repaginate with 2 questions per page.
When I press "Repaginate"
And I set the field "menuquestionsperpage" to "2"
And I press "Go"
And I click on "Go" "button" in the "Repaginate" "dialogue"
Then I should see "Essay 01 new" on quiz page "1"
And I should see "Essay 02 new" on quiz page "1"
And I should see "Essay 03 new" on quiz page "2"
@ -145,7 +145,7 @@ Feature: Edit quiz page - pagination
# Repaginate with unlimited questions per page (All questions on Page 1).
When I press "Repaginate"
And I set the field "menuquestionsperpage" to "Unlimited"
And I press "Go"
And I click on "Go" "button" in the "Repaginate" "dialogue"
Then I should see "Essay 01 new" on quiz page "1"
And I should see "Essay 02 new" on quiz page "1"
And I should see "Essay 03 new" on quiz page "1"

4
theme/boost/templates/footer.mustache
View File

@ -19,8 +19,8 @@
}}
<div id="goto-top-link">
{{! go to top is sticky to footer so needs to be sibling }}
<a class="btn btn-light" role="button" href="#">
{{#pix}} i/up, core, {{#str}} totop, theme_boost {{/str}}{{/pix}}
<a class="btn btn-light" role="button" href="#" aria-label="{{#str}} totop, theme_boost {{/str}}">
{{#pix}} i/up, core{{/pix}}
</a>
</div>
<footer id="page-footer" class="py-3 bg-dark text-light">