mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-19 14:27:22 +01:00
Code Issues Projects Releases Wiki Activity

MDL-45523 quiz Cleanup duplicate question instances.

Browse Source
This commit is contained in:
Eric Merrill 2014-05-12 16:01:32 -04:00 committed by Dan Poltawski
parent 6794a98f6c
commit 81d48fb907
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
mod/quiz/db/upgrade.php
View File

@ -576,7 +576,7 @@ function xmldb_quiz_upgrade($oldversion) {
}
$questionidtoslotrowid = $DB->get_records_menu('quiz_slots',
array('quizid' => $quiz->id), '', 'questionid, id');
array('quizid' => $quiz->id), '', 'id, questionid');
$problemfound = false;
$currentpage = 1;
@ -596,16 +596,17 @@ function xmldb_quiz_upgrade($oldversion) {
continue;
}
if (array_key_exists($questionid, $questionidtoslotrowid)) {
$key = array_search($questionid, $questionidtoslotrowid);
if ($key !== false) {
// Normal case. quiz_slots entry is present.
// Just need to add slot and page.
$quizslot = new stdClass();
$quizslot->id = $questionidtoslotrowid[$questionid];
$quizslot->id = $key;
$quizslot->slot = $slot;
$quizslot->page = $currentpage;
$DB->update_record('quiz_slots', $quizslot);
unset($questionidtoslotrowid[$questionid]); // So we can do a sanity check later.
unset($questionidtoslotrowid[$key]); // So we can do a sanity check later.
$slot++;
continue;
@ -650,11 +651,11 @@ function xmldb_quiz_upgrade($oldversion) {
// quiz_slots rows linked to this quiz.
if (!empty($questionidtoslotrowid)) {
debugging('During upgrade, detected that questions ' .
implode(', ', array_keys($questionidtoslotrowid)) .
implode(', ', array_values($questionidtoslotrowid)) .
' had instances in quiz ' . $quiz->id . ' but were not actually used. ' .
'The instances have been removed.', DEBUG_NORMAL);
$DB->delete_records_list('quiz_slots', 'id', array_values($questionidtoslotrowid));
$DB->delete_records_list('quiz_slots', 'id', array_keys($questionidtoslotrowid));
$problemfound = true;
}