mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-16 14:02:32 +02:00
Code Issues Projects Releases Wiki Activity

MDL-50583 upgrade: Optimize upgrade_minmaxgrade

Browse Source 
Reverse join order to use existing database keys. Changed query to use the
more easily read NOT IN.
This commit is contained in:
GeekSmith 2015-06-12 16:21:50 -04:00 committed by David Monllao
parent f1a415ea70
commit 82cca1ab16
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/upgradelib.php
View File

@ -2303,10 +2303,10 @@ function upgrade_minmaxgrade() {
// Identify the courses that have inconsistencies grade_item vs grade_grade.
$sql = "SELECT DISTINCT(gi.courseid)
FROM {grade_items} gi
JOIN {grade_grades} gg
FROM {grade_grades} gg
JOIN {grade_items} gi
ON gg.itemid = gi.id
WHERE (gi.itemtype != ? AND gi.itemtype != ?)
WHERE gi.itemtype NOT IN (?, ?)
AND (gg.rawgrademax != gi.grademax OR gg.rawgrademin != gi.grademin)";
$rs = $DB->get_recordset_sql($sql, array('course', 'category'));