From 79cc1c4ff6defa5a027b51fd48222f9563e789c2 Mon Sep 17 00:00:00 2001 From: Juan Leyva Date: Fri, 3 Feb 2017 17:23:57 +0100 Subject: [PATCH] MDL-57868 mod_feedback: Fix incorrect query parameters order get_records_menu call get_records using the same params ordering, it is causing a duplicated value error for the first column --- mod/feedback/lib.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mod/feedback/lib.php b/mod/feedback/lib.php index cee0cc64dbc..1ecbc4cccae 100644 --- a/mod/feedback/lib.php +++ b/mod/feedback/lib.php @@ -997,10 +997,9 @@ function feedback_get_incomplete_users(cm_info $cm, //now get all completeds $params = array('feedback'=>$cm->instance); - if (!$completedusers = $DB->get_records_menu('feedback_completed', $params, '', 'userid,id')) { + if (!$completedusers = $DB->get_records_menu('feedback_completed', $params, '', 'id, userid')) { return $allusers; } - $completedusers = array_keys($completedusers); //now strike all completedusers from allusers $allusers = array_diff($allusers, $completedusers);