From 8472a14d71dedc5c56732bc785242135a8a243a0 Mon Sep 17 00:00:00 2001 From: tjhunt Date: Thu, 13 Sep 2007 16:25:00 +0000 Subject: [PATCH] MDL-11213 - Quiz preview attempts show up in item analysis. Fix thanks to Jean-Michel Vedrine. Merged from MOODLE_18_STABLE. --- mod/quiz/report/analysis/report.php | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/mod/quiz/report/analysis/report.php b/mod/quiz/report/analysis/report.php index 0011c27a318..388721be299 100644 --- a/mod/quiz/report/analysis/report.php +++ b/mod/quiz/report/analysis/report.php @@ -68,7 +68,10 @@ class quiz_report extends quiz_default_report { } if ($attemptselection != QUIZ_ALLATTEMPTS) { - $sql = 'SELECT qa.userid '.$limit.'FROM '.$CFG->prefix.'user u LEFT JOIN '.$CFG->prefix.'quiz_attempts qa ON u.id = qa.userid '. 'WHERE ( qa.quiz = '.$quiz->id.') '.$group; + $sql = 'SELECT qa.userid '.$limit. + 'FROM '.$CFG->prefix.'user u LEFT JOIN '.$CFG->prefix.'quiz_attempts qa ON u.id = qa.userid '. + 'WHERE qa.quiz = '.$quiz->id.' AND qa.preview = 0 '. + $group; $usermax = get_records_sql_menu($sql); } @@ -82,7 +85,7 @@ class quiz_report extends quiz_default_report { } $sql = 'SELECT qa.* FROM '.$CFG->prefix.'quiz_attempts qa, '.$CFG->prefix.'user u '.$groupmembers. - 'WHERE u.id = qa.userid AND qa.quiz = '.$quiz->id.' AND ( qa.sumgrades >= '.$scorelimit.' ) '.$groupwhere; + 'WHERE u.id = qa.userid AND qa.quiz = '.$quiz->id.' AND qa.preview = 0 AND ( qa.sumgrades >= '.$scorelimit.' ) '.$groupwhere; // ^^^^^^ es posible seleccionar aqu� TODOS los quizzes, como quiere Jussi, // pero habr�a que llevar la cuenta ed cada quiz para restaura las preguntas (quizquestions, states) @@ -91,7 +94,7 @@ class quiz_report extends quiz_default_report { $attempts = get_records_sql($sql); if(empty($attempts)) { - ($strnoattempts); + print_heading(get_string('nothingtodisplay')); $this->print_options_form($quiz, $cm, $attemptselection, $lowmarklimit, $pagesize); return true; }