mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-17 13:38:32 +01:00
Code Issues Projects Releases Wiki Activity

MDL-55376 mod_assign: Fix bug stopping admin from editing submissions

Browse Source
This commit is contained in:
Cameron Ball 2016-07-29 17:39:10 +08:00
parent 90a8bdbfc0
commit 867b413181
No known key found for this signature in database
GPG Key ID: 305B7F70214D810C
2 changed files with 55 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
mod/assign/submission_form.php
View File

@ -44,12 +44,11 @@ class mod_assign_submission_form extends moodleform {
global $USER;
$mform = $this->_form;
list($assign, $data) = $this->_customdata;
$instance = $assign->get_instance();
if ($instance->teamsubmission) {
$submission = $assign->get_group_submission($USER->id, 0, true);
$submission = $assign->get_group_submission($data->userid, 0, true);
} else {
$submission = $assign->get_user_submission($USER->id, true);
$submission = $assign->get_user_submission($data->userid, true);
}
if ($submission) {
$mform->addElement('hidden', 'lastmodified', $submission->timemodified);

53
mod/assign/tests/behat/edit_student_submission.feature Normal file
View File

@ -0,0 +1,53 @@
@mod @mod_assign @javascript
Feature: In an assignment, the administrator can edit students' submissions
In order to edit a student's submissions
As an administrator
I need to grade multiple students on one page
Scenario: Editing a student's submission
Given the following "courses" exist:
| fullname | shortname | category | groupmode |
| Course 1 | C1 | 0 | 1 |
And the following "users" exist:
| username | firstname | lastname | email |
| student1 | Student | 1 | student1@example.com |
And the following "course enrolments" exist:
| user | course | role |
| student1 | C1 | student |
When I log in as "admin"
And I am on site homepage
And I follow "Course 1"
And I turn editing mode on
And I add a "Assignment" to section "1" and I fill the form with:
| Assignment name | Test assignment name |
| Description | Submit your online text |
| assignsubmission_onlinetext_enabled | 1 |
| groupmode | No groups |
And I log out
And I log in as "student1"
And I follow "Course 1"
And I follow "Test assignment name"
And I press "Add submission"
And I set the following fields to these values:
| Online text | I'm the student1 submission |
And I press "Save changes"
And I log out
And I log in as "admin"
And I am on site homepage
And I follow "Course 1"
And I follow "Test assignment name"
And I follow "View all submissions"
And I click on "Edit" "link" in the "Student 1" "table_row"
And I follow "Edit submission"
And I set the following fields to these values:
| Online text | Have you seen the movie Chef? |
And I press "Save changes"
And I follow "View all submissions"
Then I should see "Have you seen the movie Chef?"
And I click on "Edit" "link" in the "Student 1" "table_row"
And I follow "Edit submission"
And I set the following fields to these values:
| Online text | I have seen the movie chef. |
And I press "Save changes"
And I follow "View all submissions"
Then I should see "I have seen the movie chef."