mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-01-18 22:08:20 +01:00
Code Issues Projects Releases Wiki Activity

MDL-32246 question export: should cope with unrecognised qtypes.

Browse Source 
If a question is of an unrecognised type, then we just omit it from the export.
This commit is contained in:
Tim Hunt 2012-03-28 16:52:57 +01:00
parent a280078197
commit 87b564df81
2 changed files with 15 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
question/editlib.php
View File

@ -54,15 +54,11 @@ function get_module_from_cmid($cmid) {
* @param bool $noparent if true only questions with NO parent will be selected
* @param bool $recurse include subdirectories
* @param bool $export set true if this is called by questionbank export
* @author added by Howard Miller June 2004
*/
function get_questions_category( $category, $noparent=false, $recurse=true, $export=true ) {
global $DB;
// questions will be added to an array
$qresults = array();
// build sql bit for $noparent
// Build sql bit for $noparent
$npsql = '';
if ($noparent) {
$npsql = " and parent='0' ";
@ -75,16 +71,21 @@ function get_questions_category( $category, $noparent=false, $recurse=true, $exp
$categorylist = array($category->id);
}
// get the list of questions for the category
// Get the list of questions for the category
list($usql, $params) = $DB->get_in_or_equal($categorylist);
if ($questions = $DB->get_records_select('question', "category $usql $npsql", $params, 'qtype, name')) {
$questions = $DB->get_records_select('question', "category $usql $npsql", $params, 'qtype, name');
// iterate through questions, getting stuff we need
foreach($questions as $question) {
$question->export_process = $export;
question_bank::get_qtype($question->qtype)->get_question_options($question);
$qresults[] = $question;
// Iterate through questions, getting stuff we need
$qresults = array();
foreach($questions as $key => $question) {
$question->export_process = $export;
$qtype = question_bank::get_qtype($question->qtype, false);
if ($export && $qtype->name() == 'missingtype') {
// Unrecognised question type. Skip this question when exporting.
continue;
}
$qtype->get_question_options($question);
$qresults[] = $question;
}
return $qresults;

3
question/export.php
View File

@ -44,7 +44,8 @@ $PAGE->set_title($strexportquestions);
$PAGE->set_heading($COURSE->fullname);
echo $OUTPUT->header();
$export_form = new question_export_form($thispageurl, array('contexts'=>$contexts->having_one_edit_tab_cap('export'), 'defaultcategory'=>$pagevars['cat']));
$export_form = new question_export_form($thispageurl,
array('contexts' => $contexts->having_one_edit_tab_cap('export'), 'defaultcategory' => $pagevars['cat']));
if ($from_form = $export_form->get_data()) {