mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-22 17:02:03 +02:00
Code Issues Projects Releases Wiki Activity

Prevent add_field() to work if we are adding one not null field

Browse Source 
to one non-empty table without specifying its default value.

Merged from MOODLE_17_STABLE
This commit is contained in:
stronk7 2006-10-21 18:19:47 +00:00
parent e0251aea34
commit 8914508a4b
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/ddllib.php
View File

@ -678,6 +678,12 @@ function add_field($table, $field, $continue=true, $feedback=true) {
return true;
}
/// If NOT NULL and no default given, check the table is empty
if ($field->getNotNull() && $field->getDefault() === NULL && count_records($table->getName())) {
debugging('Field ' . $field->getName() . ' cannot be added. Not null fields added to non empty tables require default value. Create skipped', DEBUG_DEVELOPER);
return true;
}
if(!$sqlarr = $table->getAddFieldSQL($CFG->dbtype, $CFG->prefix, $field, false)) {
return true; //Empty array = nothing to do = no error
}