mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-21 00:12:56 +02:00
Code Issues Projects Releases Wiki Activity

MDL-29350 Prevent memory/time problems if there are zillions of combinations

Browse Source
This commit is contained in:
Eloy Lafuente (stronk7) 2011-11-17 20:10:02 +01:00
parent 408ea3b547
commit 8a9426bc17
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/db/upgrade.php
View File

@ -6917,15 +6917,17 @@ FROM
}
if ($oldversion < 2011111500.01) {
upgrade_set_timeout(60*20); // this may take a while
// Remove duplicate entries from groupings_groups table
$sql = 'SELECT MIN(id) AS firstid, groupingid, groupid FROM {groupings_groups} '.
'GROUP BY groupingid, groupid HAVING COUNT(id)>1';
$badrecs = $DB->get_records_sql($sql);
foreach ($badrecs as $badrec) {
$badrs = $DB->get_recordset_sql($sql);
foreach ($badrs as $badrec) {
$where = 'groupingid = ? and groupid = ? and id > ?';
$params = array($badrec->groupingid, $badrec->groupid, $badrec->firstid);
$DB->delete_records_select('groupings_groups', $where, $params);
}
$badrs->close();
// Main savepoint reached
upgrade_main_savepoint(true, 2011111500.01);