From 8a948bfc9aaefc6b308dcfffd9204b3e0a9e6740 Mon Sep 17 00:00:00 2001
From: jerome <jerome>
Date: Mon, 16 Mar 2009 05:54:28 +0000
Subject: [PATCH] web service MDL-12886 restrict return type for
 get_groupmembers

---
 group/external.php | 27 +++++++++++++++++++++++----
 1 file changed, 23 insertions(+), 4 deletions(-)

diff --git a/group/external.php b/group/external.php
index 3f591980b95..db6bcc4dbc7 100644
--- a/group/external.php
+++ b/group/external.php
@@ -114,9 +114,31 @@ final class group_external {
         if (has_capability('moodle/course:managegroups', get_context_instance(CONTEXT_SYSTEM))) {
             $members = array();
             foreach ($params as $groupid) {
+
                 $groupmembers = groups_get_members($groupid);
-                $members[] = array("groupid" => $groupid, "members" => $groupmembers);
+                varlog($groupmembers);
+                $custommembers = array();
+                foreach ($groupmembers as $member) {
+                    $custommember = new stdClass();
+                    $custommember->username =  $member->username;
+                    $custommember->auth =  $member->auth;
+                    $custommember->confirmed =  $member->confirmed;
+                    $custommember->idnumber =  $member->idnumber;
+                    $custommember->firstname =  $member->firstname;
+                    $custommember->lastname =  $member->lastname;
+                    $custommember->email =  $member->email;
+                    $custommember->emailstop =  $member->emailstop;
+                    $custommember->lang =  $member->lang;
+                    $custommember->id =  $member->id;
+                    $custommember->theme =  $member->theme;
+                    $custommember->timezone =  $member->timezone;
+                    $custommember->mailformat =  $member->mailformat;
+                    $custommembers[] = $custommember;
+                }
+                 
+                $members[] = array("groupid" => $groupid, "members" => $custommembers);
             }
+            varlog($members);
             return $members;
         }
         else {
@@ -139,9 +161,6 @@ final class group_external {
                 $groupid = clean_param($member['groupid'], PARAM_INTEGER);
                 $userid = clean_param($member['userid'], PARAM_INTEGER);
 
-                //check that the user is participant of the course
-                
-
                 if (!groups_add_member($groupid, $userid)) {
                     $addmembersuccessfull = false;
                 }