From 8c4d80f130f2012b96bdfe9749842c94ce21f7bd Mon Sep 17 00:00:00 2001 From: nicolasconnault Date: Wed, 18 Jul 2007 03:57:50 +0000 Subject: [PATCH] MDL-10392 completed: the finalgrade value wasn't assigned to the grade_grades object when its update() method was being called. --- grade/edit/grade.php | 5 ++++- lang/en_utf8/grades.php | 3 +++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/grade/edit/grade.php b/grade/edit/grade.php index 6aabe082bcf..cc3d7f7ffd6 100644 --- a/grade/edit/grade.php +++ b/grade/edit/grade.php @@ -52,13 +52,16 @@ if ($mform->is_cancelled()) { redirect($returnurl); // form processing } else if ($data = $mform->get_data()) { - $grade_grades = new grade_grades(array('id'=>$id)); $grade_item = new grade_item(array('id'=>$grade_grades->itemid)); $grade_item->update_final_grade($grade_grades->userid, $data->finalgrade, NULL, NULL, $data->feedback, $data->feedbackformat); + // Assign finalgrade value + $grade_grades->finalgrade = $data->finalgrade; + // set locked $grade_grades->set_locked($data->locked); + // set hidden $grade_grades->set_hidden($data->hidden); diff --git a/lang/en_utf8/grades.php b/lang/en_utf8/grades.php index 0208691ab09..c452ea03a39 100644 --- a/lang/en_utf8/grades.php +++ b/lang/en_utf8/grades.php @@ -91,6 +91,7 @@ $string['feedbackadd'] = 'Add feedback'; $string['feedbackedit'] = 'Edit feedback'; $string['feedbackview'] = 'View feedback'; $string['feedbacksaved'] = 'Feedback saved'; +$string['finalgrade'] = 'Final grade'; $string['forelementtypes'] = ' for the selected $a'; $string['forstudents'] = 'For Students'; $string['full'] = 'Full'; @@ -116,6 +117,7 @@ $string['gradeletternote'] = 'To delete a grade letter just empty any of the