mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-19 07:25:30 +02:00
Code Issues Projects Releases Wiki Activity

MDL-74421 core_admin: Task log classname filter should be clearer

Browse Source 
Change filter title from 'Name' to 'Class name' to indicate that
it only filters the classname, not the display name of the task.
This commit is contained in:
sam marshall 2022-04-04 11:39:04 +01:00
parent b5f51883f0
commit 8c926d5cca
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
admin/classes/local/entities/task_log.php
View File

@ -243,7 +243,7 @@ class task_log extends base {
$filters[] = (new filter(
text::class,
'name',
new lang_string('name'),
new lang_string('classname', 'tool_task'),
$this->get_entity_name(),
"{$tablealias}.classname"
))

6
admin/tests/behat/task_logs.feature
View File

@ -14,9 +14,9 @@ Feature: View task logs report and use its filters
And I change window size to "large"
And I navigate to "Server > Tasks > Task logs" in site administration
When I click on "Filters" "button"
And I set the following fields in the "Name" "core_reportbuilder > Filter" to these values:
| Name operator | Contains |
| Name value | <name> |
And I set the following fields in the "Class name" "core_reportbuilder > Filter" to these values:
| Class name operator | Contains |
| Class name value | <name> |
And I click on "Apply" "button" in the "[data-region='report-filters']" "css_element"
Then I should see "Filters applied"
And I should see "Filters (1)" in the "#dropdownFiltersButton" "css_element"