mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-03-22 08:30:04 +01:00
Code Issues Projects Releases Wiki Activity

MDL-66915 assign: Notify only if grade was updated in past 24 hours

Browse Source 
Send notifications only if a grade was updated in the past 24 hours,
whether marking workflow is enabled or not.
This commit is contained in:
Martin Gauk 2019-10-15 17:03:33 +02:00
parent 8111abc331
commit 8d5b7fc6cd
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
mod/assign/locallib.php
View File

@ -2516,8 +2516,8 @@ class assign {
// - The assignment is visible in the gradebook.
// - No previous notification has been sent.
// - The grader was a real user, not an automated process.
// - If marking workflow is not enabled, the grade was updated in the past 24 hours, or
// if marking workflow is enabled, the workflow state is at 'released'.
// - The grade was updated in the past 24 hours.
// - If marking workflow is enabled, the workflow state is at 'released'.
$sql = "SELECT g.id as gradeid, a.course, a.name, a.blindmarking, a.revealidentities, a.hidegrader,
g.*, g.timemodified as lastmodified, cm.id as cmid, um.id as recordid
FROM {assign} a
@ -2527,9 +2527,9 @@ class assign {
JOIN {modules} md ON md.id = cm.module AND md.name = 'assign'
JOIN {grade_items} gri ON gri.iteminstance = a.id AND gri.courseid = a.course AND gri.itemmodule = md.name
LEFT JOIN {assign_user_mapping} um ON g.id = um.userid AND um.assignment = a.id
WHERE ((a.markingworkflow = 0 AND g.timemodified >= :yesterday AND g.timemodified <= :today) OR
(a.markingworkflow = 1 AND uf.workflowstate = :wfreleased)) AND
g.grader > 0 AND uf.mailed = 0 AND gri.hidden = 0
WHERE (a.markingworkflow = 0 OR (a.markingworkflow = 1 AND uf.workflowstate = :wfreleased)) AND
g.grader > 0 AND uf.mailed = 0 AND gri.hidden = 0 AND
g.timemodified >= :yesterday AND g.timemodified <= :today
ORDER BY a.course, cm.id";
$params = array(