MDL-68998 core_course: do not expect that assign is the first module

This commit is contained in:
Marina Glancy 2020-06-09 17:52:43 +02:00
parent 71a34a039f
commit 8eaad10b5f

View File

@ -51,15 +51,15 @@ class caching_content_item_readonly_repository_testcase extends \advanced_testca
// Get the content items using both the live and the caching repos.
$items = $cir->find_all_for_course($course, $user);
$cacheditems = $ccir->find_all_for_course($course, $user);
$itemsfiltered = array_filter($items, function($item) {
return $item->get_component_name() == 'mod_assign';
});
$cacheditemsfiltered = array_filter($cacheditems, function($item) {
return $item->get_component_name() == 'mod_assign';
});
$itemsfiltered = array_values(array_filter($items, function($item) {
return $item->get_component_name() == 'mod_book';
}));
$cacheditemsfiltered = array_values(array_filter($cacheditems, function($item) {
return $item->get_component_name() == 'mod_book';
}));
// Verify the assign module is in both result sets.
$module = $DB->get_record('modules', ['name' => 'assign']);
// Verify the book module is in both result sets.
$module = $DB->get_record('modules', ['name' => 'book']);
$this->assertEquals($module->name, $itemsfiltered[0]->get_name());
$this->assertEquals($module->name, $cacheditemsfiltered[0]->get_name());
@ -67,12 +67,12 @@ class caching_content_item_readonly_repository_testcase extends \advanced_testca
$DB->set_field("modules", "visible", "0", ["id" => $module->id]);
$items = $cir->find_all_for_course($course, $user);
$cacheditems = $ccir->find_all_for_course($course, $user);
$itemsfiltered = array_filter($items, function($item) {
return $item->get_component_name() == 'mod_assign';
});
$cacheditemsfiltered = array_filter($cacheditems, function($item) {
return $item->get_component_name() == 'mod_assign';
});
$itemsfiltered = array_values(array_filter($items, function($item) {
return $item->get_component_name() == 'mod_book';
}));
$cacheditemsfiltered = array_values(array_filter($cacheditems, function($item) {
return $item->get_component_name() == 'mod_book';
}));
// The caching repo should return the same list, while the live repo will return the updated list.
$this->assertEquals($module->name, $cacheditemsfiltered[0]->get_name());