mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-21 16:32:18 +02:00
Code Issues Projects Releases Wiki Activity

MDL-53778 quiz settings: Ensure that disabled checkboxes have value 0

Browse Source
This commit is contained in:
Arto Nieminen 2019-06-07 10:27:47 +03:00
parent f1a8db6911
commit 9147273640
2 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
mod/quiz/lib.php
View File

@ -1128,6 +1128,14 @@ function quiz_process_options($quiz) {
$quiz->reviewoverallfeedback = quiz_review_option_form_to_db($quiz, 'overallfeedback');
$quiz->reviewattempt |= mod_quiz_display_options::DURING;
$quiz->reviewoverallfeedback &= ~mod_quiz_display_options::DURING;
// Ensure that disabled checkboxes in completion settings are set to 0.
if (empty($quiz->completionusegrade)) {
$quiz->completionpass = 0;
}
if (empty($quiz->completionpass)) {
$quiz->completionattemptsexhausted = 0;
}
}
/**

5
mod/quiz/mod_form.php
View File

@ -517,11 +517,6 @@ class mod_quiz_mod_form extends moodleform_mod {
$toform[$name] = $value;
}
}
// Completion settings check.
if (empty($toform['completionusegrade'])) {
$toform['completionpass'] = 0; // Forced unchecked.
}
}
public function validation($data, $files) {