From 229278a71bcb6a62c52b35fa9cba0701d89d3233 Mon Sep 17 00:00:00 2001 From: "Gerard (Gerry) Caulfield" Date: Thu, 22 Dec 2011 14:00:44 +0800 Subject: [PATCH] MDL-29400 Fixing unset object bug encountered by Rajesh during testing --- mod/assignment/type/upload/assignment.class.php | 2 +- mod/assignment/type/uploadsingle/assignment.class.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mod/assignment/type/upload/assignment.class.php b/mod/assignment/type/upload/assignment.class.php index 5c993f9ec07..44d10c9c057 100644 --- a/mod/assignment/type/upload/assignment.class.php +++ b/mod/assignment/type/upload/assignment.class.php @@ -1052,7 +1052,7 @@ class assignment_upload extends assignment_base { } // If the user has submitted something add some related links and data - if ($submission->data2 == 'submitted') { + if (isset($submission->data2) AND $submission->data2 == 'submitted') { // Add a view link to the settings nav $link = new moodle_url('/mod/assignment/view.php', array('id'=>$this->cm->id)); $node->add(get_string('viewmysubmission', 'assignment'), $link, navigation_node::TYPE_SETTING); diff --git a/mod/assignment/type/uploadsingle/assignment.class.php b/mod/assignment/type/uploadsingle/assignment.class.php index 73ad5179aac..03f91af07b2 100644 --- a/mod/assignment/type/uploadsingle/assignment.class.php +++ b/mod/assignment/type/uploadsingle/assignment.class.php @@ -319,7 +319,7 @@ class assignment_uploadsingle extends assignment_base { } // If the user has submitted something add some related links and data - if ($submission->numfiles) { + if (isset($submission->numfiles) AND $submission->numfiles) { // Add a view link to the settings nav $link = new moodle_url('/mod/assignment/view.php', array('id'=>$this->cm->id)); $node->add(get_string('viewmysubmission', 'assignment'), $link, navigation_node::TYPE_SETTING);