mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-23 09:23:09 +02:00
Code Issues Projects Releases Wiki Activity

MDL-46171 assign: Fix for the update script on MySQL.

Browse Source
This commit is contained in:
Damyon Wiese 2014-09-30 21:16:24 +08:00
parent 73a37dff73
commit 93c51a1d0a
1 changed files with 13 additions and 7 deletions

20
mod/assign/db/upgrade.php

@ -537,13 +537,19 @@ function xmldb_assign_upgrade($oldversion) {
FROM {assign_submission}
GROUP BY assignment, groupid, userid';
$maxattemptidssql = 'SELECT souter.id
FROM {assign_submission} souter
JOIN (' . $maxattemptsql . ') sinner
ON souter.assignment = sinner.assignment
AND souter.userid = sinner.userid
AND souter.groupid = sinner.groupid
AND souter.attemptnumber = sinner.maxattempt';
// Note: souterouter looks redundant below, but it forces
// MySQL to use an in memory table to store the results of the
// inner query. Without this MySQL would complain that the UPDATE
// is operating on the same table as the FROM (which is true).
$maxattemptidssql = 'SELECT souterouter.id FROM (
SELECT souter.id
FROM {assign_submission} souter
JOIN (' . $maxattemptsql . ') sinner
ON souter.assignment = sinner.assignment
AND souter.userid = sinner.userid
AND souter.groupid = sinner.groupid
AND souter.attemptnumber = sinner.maxattempt
) souterouter';
$select = 'id IN(' . $maxattemptidssql . ')';
$DB->set_field_select('assign_submission', 'latest', 1, $select);