mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-04-13 12:32:08 +02:00
Code Issues Projects Releases Wiki Activity

MDL-12249 fixed small group ration, can be overriden from config.php now; merged from MOODLE_19_STABLE

Browse Source
This commit is contained in:
skodak 2007-11-19 21:41:02 +00:00
parent f16fa0a34b
commit 9509119b0e
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
group/autogroup.php
View File

@ -12,7 +12,9 @@ require_once('../config.php');
require_once('lib.php');
require_once('autogroup_form.php');
define('AUTOGROUP_MIN_RATIO', 0.7);
if (!defined('AUTOGROUP_MIN_RATIO')) {
define('AUTOGROUP_MIN_RATIO', 0.7); // means minimum member count is 70% in the smallest group
}
$courseid = required_param('courseid', PARAM_INT);
@ -104,7 +106,7 @@ if ($editform->is_cancelled()) {
if (!empty($data->nosmallgroups) and $usercnt % $data->number != 0) {
// If there would be one group with a small number of member reduce the number of groups
$missing = $userpergrp * $numgrps - $usercnt;
if ($missing > $userpergrp * AUTOGROUP_MIN_RATIO) {
if ($missing > $userpergrp * (1-AUTOGROUP_MIN_RATIO)) {
$numgrps--;
$userpergrp = ceil($usercnt/$numgrps);
}